HADOOP-19475. Update Boost to 1.86.0 #7444
Open
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
Afraid you'll have to work out why the build doesn't build. Other than that though, I'm happy |
|
💔 -1 overall
This message was automatically generated. |
cnauroth
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Thank you for the patch, @stoty .
Line 9 of BUILDING.txt has another mention of the Boost version number in a comment. Can you please update it there too?
The last CI run showed a protoc failure in hadoop-yarn-csi:
[INFO] --- protobuf-maven-plugin:0.5.1:compile-custom (default) @ hadoop-yarn-csi ---
[INFO] Compiling 1 proto file(s) to /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/generated-sources/protobuf/grpc-java
[ERROR] PROTOC FAILED: /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe: /usr/lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe)
/home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe: /usr/lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe)
/home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe)
--grpc-java_out: protoc-gen-grpc-java: Plugin failed with status code 1.
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/src/main/proto/csi.proto [0:0]: /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe: /usr/lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe)
/home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe: /usr/lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe)
/home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-7444/centos-7/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/target/protoc-plugins/protoc-gen-grpc-java-1.69.0-linux-x86_64.exe)
--grpc-java_out: protoc-gen-grpc-java: Plugin failed with status code 1.
I tried your patch locally, and I couldn't reproduce this. Let's see what the next CI run does.
|
Thank you, done. |
|
💔 -1 overall
This message was automatically generated. |
|
I get the same C compiler errors in my other patch that only ever touches Java code. |
|
If Centos 7 wasn't very EOL, I'd say that its C libraries have been updated, but that's unlikely. |
cnauroth
reviewed
Mar 8, 2025
There was a problem hiding this comment.
Thank you for the update.
The YARN test failures are unrelated, due to YARN-11793, which I've just reverted.
I still don't have an answer on the protoc problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Update Boost library version to 1.86.0
How was this patch tested?
Test suite on CI
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?