HADOOP-19480. Upgrades AAL version to 1.0.0. #7469

ahmarsuhail · 2025-03-05T13:08:04Z

Description of PR

Latest version of AAL is now available, changes since 0.0.4:

Moves all logging to debug
Adds in timeout and retries to requests to mitigate (very rare) hanging seen when reading from AsyncClient, related github issue: ByteBufferStoringSubscriber.blockingTransferTo hanging indefinitely aws/aws-sdk-java-v2#5755

How was this patch tested?

Ran ITestS3AAnalyticsAcceleratorStreamReading, will run the test suite once it's available in Maven!

ahmarsuhail · 2025-03-05T13:13:06Z

@mukund-thakur @steveloughran - PR to use AAL 1.0.0. No major changes since 0.0.4, moves logging to debug and adds timeouts and retries for a hanging issue we're seeing (happens really rarely)

fuatbasik · 2025-03-05T13:16:52Z

...op-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AAnalyticsAcceleratorStreamReading.java

@@ -64,8 +64,6 @@
 public class ITestS3AAnalyticsAcceleratorStreamReading extends AbstractS3ATestBase {

  private static final String PHYSICAL_IO_PREFIX = "physicalio";


we can get rid of this private static final String PHYSICAL_IO_PREFIX = "physicalio"; too right?

no it's used in the last test

hadoop-yetus · 2025-03-05T15:24:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 16s		trunk passed
+1 💚	compile	0m 44s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 42s		trunk passed
+1 💚	javadoc	0m 43s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 33s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 8s		trunk passed
+1 💚	shadedclient	39m 43s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 34s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 41s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 23s	/results-checkstyle-hadoop-tools_hadoop-aws.txt	hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	mvnsite	0m 35s		the patch passed
+1 💚	javadoc	0m 30s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 25s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 6s		the patch passed
+1 💚	shadedclient	38m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 17s		hadoop-aws in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		134m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7469/1/artifact/out/Dockerfile
GITHUB PR	#7469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 560005743fdb 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `425edc0`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7469/1/testReport/
Max. process+thread count	527 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7469/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

+1 pending the artifact release

mukund-thakur · 2025-03-05T20:52:40Z

hadoop-tools/hadoop-aws/pom.xml

@@ -487,6 +487,7 @@
    <dependency>
      <groupId>software.amazon.s3.analyticsaccelerator</groupId>
      <artifactId>analyticsaccelerator-s3</artifactId>
+      <version>1.0.0</version>


better create a property name for this. Also why don't I see older version here in the diff?

thanks @mukund-thakur.. I'd updated the version in the wrong place! updated in hadoop-project, which also has a property name already

hadoop-yetus · 2025-03-06T14:40:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 2s		codespell was not available.
+0 🆗	detsecrets	0m 2s		detect-secrets was not available.
+0 🆗	xmllint	0m 2s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	5m 47s		Maven dependency ordering for branch
+1 💚	mvninstall	37m 11s		trunk passed
+1 💚	compile	17m 50s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	15m 48s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	4m 33s		trunk passed
+1 💚	mvnsite	1m 34s		trunk passed
+1 💚	javadoc	1m 29s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	1m 22s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+0 🆗	spotbugs	0m 44s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	38m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 44s		the patch passed
+1 💚	compile	16m 46s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	16m 46s		the patch passed
+1 💚	compile	15m 28s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	15m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 36s		the patch passed
+1 💚	mvnsite	1m 27s		the patch passed
+1 💚	javadoc	1m 25s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	1m 23s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+0 🆗	spotbugs	0m 36s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	38m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 35s		hadoop-project in the patch passed.
+1 💚	unit	3m 20s		hadoop-aws in the patch passed.
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		218m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7469/2/artifact/out/Dockerfile
GITHUB PR	#7469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux ad14e7fa7a3e 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7492d1e`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7469/2/testReport/
Max. process+thread count	524 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-tools/hadoop-aws U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7469/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ahmarsuhail · 2025-03-06T19:38:39Z

Artefacts in maven: https://repo1.maven.org/maven2/software/amazon/s3/analyticsaccelerator/analyticsaccelerator-s3/1.0.0/, all tests pass. Merging

upgrades AAL version to 1.0.0

425edc0

github-actions bot added build trunk TOOLS AWS labels Mar 5, 2025

fuatbasik reviewed Mar 5, 2025

View reviewed changes

steveloughran approved these changes Mar 5, 2025

View reviewed changes

mukund-thakur reviewed Mar 5, 2025

View reviewed changes

updates dependency in hadoop-project

7492d1e

mukund-thakur approved these changes Mar 6, 2025

View reviewed changes

ahmarsuhail merged commit 55e0f0a into apache:trunk Mar 6, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19480. Upgrades AAL version to 1.0.0. #7469

HADOOP-19480. Upgrades AAL version to 1.0.0. #7469

ahmarsuhail commented Mar 5, 2025

ahmarsuhail commented Mar 5, 2025

fuatbasik Mar 5, 2025

ahmarsuhail Mar 5, 2025

hadoop-yetus commented Mar 5, 2025

steveloughran left a comment

mukund-thakur Mar 5, 2025

ahmarsuhail Mar 6, 2025

hadoop-yetus commented Mar 6, 2025

ahmarsuhail commented Mar 6, 2025

		@@ -64,8 +64,6 @@
		public class ITestS3AAnalyticsAcceleratorStreamReading extends AbstractS3ATestBase {

		private static final String PHYSICAL_IO_PREFIX = "physicalio";

HADOOP-19480. Upgrades AAL version to 1.0.0. #7469

HADOOP-19480. Upgrades AAL version to 1.0.0. #7469

Conversation

ahmarsuhail commented Mar 5, 2025

Description of PR

How was this patch tested?

ahmarsuhail commented Mar 5, 2025

fuatbasik Mar 5, 2025

Choose a reason for hiding this comment

ahmarsuhail Mar 5, 2025

Choose a reason for hiding this comment

hadoop-yetus commented Mar 5, 2025

steveloughran left a comment

Choose a reason for hiding this comment

mukund-thakur Mar 5, 2025

Choose a reason for hiding this comment

ahmarsuhail Mar 6, 2025

Choose a reason for hiding this comment

hadoop-yetus commented Mar 6, 2025

ahmarsuhail commented Mar 6, 2025