-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11912: Suppress Spotbugs warnings introduced in recent trunk changes #8143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zhtttylz or @slfan1989 , can I please you get your review? Thank you. |
|
#8038 has a sample CI run showing these Spotbugs warnings. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
zhtttylz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1. Thanks!
|
LGTM +1. |
|
@zhtttylz and @slfan1989 , thank you for the reviews. I committed this to trunk. |
Description of PR
Suppress Spotbugs warnings introduced in recent trunk changes
ResourceLocalizationService. HADOOP-19670. Replace Thread with SubjectPreservingThread to restore pre JDK22 Subject behaviour in Threads #8062 changed the relevant method fromrun()towork(), so the exclusion needs a corresponding change to match.ResourceManager.How was this patch tested?
mvn -o test-compile spotbugs:spotbugs -DskipTestslocally.hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/target/spotbugs.xml.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?