Skip to content

Conversation

@cnauroth
Copy link
Contributor

Description of PR

Suppress Spotbugs warnings introduced in recent trunk changes

  1. There was a pre-existing exclusion of a potential NPE warning in ResourceLocalizationService. HADOOP-19670. Replace Thread with SubjectPreservingThread to restore pre JDK22 Subject behaviour in Threads #8062 changed the relevant method from run() to work(), so the exclusion needs a corresponding change to match.
  2. The Spotbugs upgrade triggered numerous new warnings. HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version upgrade. #8053 was intended to update exclusions to cover these new warnings. I think that just missed a thread synchronization warning in ResourceManager.

How was this patch tested?

  1. Run mvn -o test-compile spotbugs:spotbugs -DskipTests locally.
  2. Confirm the warnings are no longer present in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/target/spotbugs.xml.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@cnauroth
Copy link
Contributor Author

@zhtttylz or @slfan1989 , can I please you get your review? Thank you.

@cnauroth
Copy link
Contributor Author

#8038 has a sample CI run showing these Spotbugs warnings.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 36m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 30m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
70m 28s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8143/2/artifact/out/Dockerfile
GITHUB PR #8143
Optional Tests dupname asflicense codespell detsecrets xmllint
uname Linux 2583bd3742e0 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 303e44b
Max. process+thread count 613 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8143/2/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 31m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 26m 45s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
82m 49s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8143/1/artifact/out/Dockerfile
GITHUB PR #8143
Optional Tests dupname asflicense codespell detsecrets xmllint
uname Linux 8ac4c9f4e8f0 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 303e44b
Max. process+thread count 637 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8143/1/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@zhtttylz zhtttylz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1. Thanks!

@slfan1989
Copy link
Contributor

LGTM +1.

@cnauroth cnauroth closed this in 4a82720 Dec 23, 2025
@cnauroth
Copy link
Contributor Author

@zhtttylz and @slfan1989 , thank you for the reviews. I committed this to trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants