-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19613. [3.4 Backport][ABFS][ReadAheadV2] Refactor ReadBufferManager to isolate new code with the current working code #8163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19613. [3.4 Backport][ABFS][ReadAheadV2] Refactor ReadBufferManager to isolate new code with the current working code #8163
Conversation
…te new code with the current working code (apache#7801)
|
🎊 +1 overall
This message was automatically generated. |
|
:::: AGGREGATED TEST RESULT :::: ============================================================
|
Backport PR for Commit: 9d5e111
Description of Original PR on trunk
This is the first PR in series of work done under Parent Jira: HADOOP-19596 to improve the performance of sequential reads in ABFS Driver.
Please refer to Parent JIRA for more details.
Jira: https://issues.apache.org/jira/browse/HADOOP-19613
Read Buffer Manager used today was introduced way back and has been stable for quite a while.
Read Buffer Manager to be introduced as part of HADOOP-19596 will introduce many changes incrementally over time. While the development goes on and we are able to fully stabilise the optimized version we need the current flow to be functional and undisturbed.
This work item is to isolate that from new code by refactoring ReadBufferManager class to have 2 different implementations with same public interfaces: ReadBufferManagerV1 and ReadBufferManagerV2.
This will also introduce new configs that can be used to toggle between new and old code.
How was this patch tested?
Existing tests were modified to work with the Refactored Classes.
More tests will be added with coming up PRs where new implementation will be introduced.
Test suite result added.