Skip to content

Conversation

@anujmodi2021
Copy link
Contributor

Backport PR for Commit: 9d5e111

Description of Original PR on trunk

This is the first PR in series of work done under Parent Jira: HADOOP-19596 to improve the performance of sequential reads in ABFS Driver.
Please refer to Parent JIRA for more details.

Jira: https://issues.apache.org/jira/browse/HADOOP-19613

Read Buffer Manager used today was introduced way back and has been stable for quite a while.
Read Buffer Manager to be introduced as part of HADOOP-19596 will introduce many changes incrementally over time. While the development goes on and we are able to fully stabilise the optimized version we need the current flow to be functional and undisturbed.

This work item is to isolate that from new code by refactoring ReadBufferManager class to have 2 different implementations with same public interfaces: ReadBufferManagerV1 and ReadBufferManagerV2.

This will also introduce new configs that can be used to toggle between new and old code.

How was this patch tested?

Existing tests were modified to work with the Refactored Classes.
More tests will be added with coming up PRs where new implementation will be introduced.
Test suite result added.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-3.4 Compile Tests _
+1 💚 mvninstall 24m 34s branch-3.4 passed
+1 💚 compile 0m 25s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 20s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 22s branch-3.4 passed
+1 💚 mvnsite 0m 24s branch-3.4 passed
+1 💚 javadoc 0m 24s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 21s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 42s branch-3.4 passed
+1 💚 shadedclient 19m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 18s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 14s /results-checkstyle-hadoop-tools_hadoop-azure.txt hadoop-tools/hadoop-azure: The patch generated 9 new + 3 unchanged - 0 fixed = 12 total (was 3)
+1 💚 mvnsite 0m 18s the patch passed
+1 💚 javadoc 0m 15s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 41s the patch passed
+1 💚 shadedclient 19m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 12s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
73m 35s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8163/1/artifact/out/Dockerfile
GITHUB PR #8163
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 68982da2db90 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / df8faab
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8163/1/testReport/
Max. process+thread count 558 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8163/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@anujmodi2021
Copy link
Contributor Author


:::: AGGREGATED TEST RESULT ::::

============================================================
HNS-OAuth-DFS

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 886, Failures: 0, Errors: 0, Skipped: 231
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 23

============================================================
HNS-SharedKey-DFS

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 886, Failures: 0, Errors: 0, Skipped: 180
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 10

============================================================
NonHNS-SharedKey-DFS

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 870, Failures: 0, Errors: 0, Skipped: 437
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 33
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 11

============================================================
AppendBlob-HNS-OAuth-DFS

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 886, Failures: 0, Errors: 0, Skipped: 242
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 56
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-SharedKey-Blob

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 870, Failures: 0, Errors: 0, Skipped: 288
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 11

============================================================
NonHNS-OAuth-DFS

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 870, Failures: 0, Errors: 0, Skipped: 442
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 33
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 24

============================================================
NonHNS-OAuth-Blob

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 870, Failures: 0, Errors: 0, Skipped: 303
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 24

============================================================
AppendBlob-NonHNS-OAuth-Blob

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 870, Failures: 0, Errors: 0, Skipped: 354
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 51
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 24

============================================================
HNS-Oauth-DFS-IngressBlob

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 886, Failures: 0, Errors: 0, Skipped: 366
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-OAuth-DFS-IngressBlob

[WARNING] Tests run: 178, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 870, Failures: 0, Errors: 0, Skipped: 439
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 33
[WARNING] Tests run: 274, Failures: 0, Errors: 0, Skipped: 24

Time taken: 177 mins 31 secs.

@anujmodi2021 anujmodi2021 merged commit ebc03b7 into apache:branch-3.4 Jan 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants