HBASE-28819 CanaryTool: Create canary tables in different RSgroup and… #6235
+119
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… write sniff when rsgroup is enabled
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Sep 22, 2024
| @@ -303,6 +303,7 @@ public void publishReadTiming(String znode, String server, long msTime) { | |||
| */ | |||
| public static class RegionStdOutSink extends StdOutSink { | |||
| private Map<String, LongAdder> perTableReadLatency = new HashMap<>(); | |||
| private Map<String, LongAdder> perTableWriteLatency = new HashMap<>(); | |||
There was a problem hiding this comment.
Do we still need to global writeLatency below?
| @@ -1131,8 +1134,8 @@ private void printUsageAndExit() { | |||
| System.err.println(" -f <B> exit on first error; default=true"); | |||
| System.err.println(" -failureAsError treat read/write failure as error"); | |||
| System.err.println(" -t <N> timeout for canary-test run; default=600000ms"); | |||
| System.err.println(" -writeSniffing enable write sniffing"); | |||
| System.err.println(" -writeTable the table used for write sniffing; default=hbase:canary"); | |||
There was a problem hiding this comment.
I do not think we should remove this flag? People may want to use this flag to specify a different write table for canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-28819