Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28846 Change the default Hadoop3 version to 3.4.0, and add test… #6261

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Sep 18, 2024

…s to make sure HBase works with earlier supported Hadoop versions

step 1. Change the Hadoop version to 3.4.0

@stoty stoty marked this pull request as draft September 18, 2024 11:01
@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs along with this change. Thanks @stoty

@stoty
Copy link
Contributor Author

stoty commented Sep 19, 2024

Thanks for looking into this, @ndimiduk and @Apache9 .

At this point I'm just trying to figure out how I can integrate the new tests into Jenkins, and validate them.

Do you have suggestions on the least painful way to develop and test the Jenkinsfiles ?
I'm thinking of making temporary CI jobs with local Jenkinsfiles, commeting out the slow-running stages, and working out the new tests that way. (Assuming I have the JIRA permissions for that)

…s to make sure HBase works with earlier supported Hadoop versions

step 1. Change the Hadoop version to 3.4.0
@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
Copy link
Member

Thanks for looking into this, @ndimiduk and @Apache9 .

At this point I'm just trying to figure out how I can integrate the new tests into Jenkins, and validate them.

Do you have suggestions on the least painful way to develop and test the Jenkinsfiles ?

I'm thinking of making temporary CI jobs with local Jenkinsfiles, commeting out the slow-running stages, and working out the new tests that way. (Assuming I have the JIRA permissions for that)

Yeah, unfortunately, I think you're on the right track. You could try extending the PR Jenkinsfile, which would allow you to test from the PR interface, but you'd still need to migrate it back to the nightly Jenkinsfile. If you have necessary Jenkins permissions to create and work from a dummy job, I think that will go easier.

If you need any PMC support for gaining access permissions from INFRA, don't hesitate to ping me.

@Apache-HBase

This comment has been minimized.

@ndimiduk
Copy link
Member

I'm going to unsubscribe here. Ping me again if/when you need me.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/console in case of problems.

1 similar comment
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/console in case of problems.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 5s master passed
+1 💚 compile 7m 51s master passed
+1 💚 checkstyle 1m 9s master passed
+1 💚 spotbugs 7m 36s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 2m 54s the patch passed
+1 💚 compile 7m 43s the patch passed
+1 💚 javac 7m 43s the patch passed
-0 ⚠️ blanks 0m 0s /blanks-eol.txt The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ blanks 0m 0s /blanks-tabs.txt The patch 9 line(s) with tabs.
+1 💚 checkstyle 1m 13s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 7m 57s the patch passed
+1 💚 hadoopcheck 10m 33s Patch does not cause any errors with Hadoop 3.3.5 3.4.0.
-1 ❌ spotless 0m 6s patch has 28 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
59m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6261
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti xmllint
uname Linux 52f2f6f92675 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1628e74
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 194 (vs. ulimit of 30000)
modules C: hbase-asyncfs . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 4m 49s master passed
+1 💚 compile 2m 41s master passed
+1 💚 javadoc 3m 15s master passed
+1 💚 shadedjars 6m 54s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 49s the patch passed
+1 💚 compile 2m 49s the patch passed
+1 💚 javac 2m 49s the patch passed
+1 💚 javadoc 2m 50s the patch passed
+1 💚 shadedjars 6m 58s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 299m 1s /patch-unit-root.txt root in the patch failed.
340m 2s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6261
Optional Tests javac javadoc unit compile shadedjars
uname Linux cc32f0085e18 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1628e74
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/testReport/
Max. process+thread count 5113 (vs. ulimit of 30000)
modules C: hbase-asyncfs . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6261/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants