-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "HBASE-28842 TestRequestAttributes should fail when expected (#6255)" to branch-2 #6268
base: branch-2
Are you sure you want to change the base?
Conversation
Co-authored-by: Evie Boland <[email protected]> Signed-off-by: Ray Mattingly <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Test failures look unrelated. Prompting a new test run. |
Yeah it looks to me like some of these test changes were snuck past me in the backport of HBASE-28001 to branch-2 (#6246) and branch-2.6 (#6256). Normally under such a circumstance, I find it easier to track when we re-open the original JIRA for a revert + fixes apply (ideally), or an addendum commit (unfortunately also common). I see that there is a minor inconsistency in the method signature of Let's continue as we are with the second issue. It looks to me like there will be two shapes of commit for this change. The first applies to |
🎊 +1 overall
This message was automatically generated. |
@rmdmattingly, what @ndimiduk said is correct. Apologies about the changed method signatures! |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Test failure again looks unrelated. For such a trivial diff, I'm inclined to move forward. Separately, maybe we should begin taking account of these noisy test failures. |
💔 -1 overall
This message was automatically generated. |
@eab148 am I correct that this is the only change introduced by this commit to branch-2 since this bug was discovered in the backport?