HIVE-28579: Add query id to HiveSQLException #5520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difin
force-pushed
the
fix_exception_handling
branch
from
29dcc1c
to
bb75904
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
deniskuzZ
reviewed
Oct 29, 2024
deniskuzZ
reviewed
Oct 29, 2024
deniskuzZ
reviewed
Oct 29, 2024
service/src/java/org/apache/hive/service/cli/HiveSQLException.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 29, 2024
difin
force-pushed
the
fix_exception_handling
branch
from
46fc494
to
fb79fdd
Compare
difin
force-pushed
the
fix_exception_handling
branch
from
fb79fdd
to
5649012
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
difin
force-pushed
the
fix_exception_handling
branch
from
5649012
to
00a085c
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
difin
force-pushed
the
fix_exception_handling
branch
from
00a085c
to
632e997
Compare
difin
force-pushed
the
fix_exception_handling
branch
from
7d1fa31
to
93e9a51
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
difin
force-pushed
the
fix_exception_handling
branch
from
93e9a51
to
d5e4f82
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
ayushtkn
reviewed
Nov 6, 2024
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestExceptionMessageWithJdbc.java
Outdated
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/HiveSQLException.java
Outdated
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/Operation.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests passed
tests failed
and removed
tests unstable
tests pending
tests passed
labels
difin
force-pushed
the
fix_exception_handling
branch
from
755aca2
to
8c3bacd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add query id to HiveSQLException's message. Using query id more info can easily be retrieved from Hiveserver2 log.
Why are the changes needed?
'hive.server2.async.exec.async.compile' = 'true'and an exception happens, an operational log is not displayed in Beeline and Hue (because stmtHandle is empty) and only exception message is displayed. Query id is not displayed.'hive.server2.async.exec.async.compile' = 'false'and operational log level != 'NONE', operational log is displayed with query id and exception stack trace and also exception message is displayed.When a query users should know Query ID, because using one they can find stack traces and other info in HiveServer2 log.
Does this PR introduce any user-facing change?
Yes
Is the change a dependency upgrade?
No
How was this patch tested?
Added new JDBC test to test that query id is added to exception message.