HTTPCORE-754: StrictConnPool fails to correctly handle infinite reque…

…st timeout
apache · Jun 30, 2023 · 277370d · 277370d
1 parent 8f7a7c2
commit 277370d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/pool/StrictConnPool.java b/httpcore5/src/main/java/org/apache/hc/core5/pool/StrictConnPool.java
@@ -192,7 +192,12 @@ public synchronized PoolEntry<T, C> get(
         final boolean acquiredLock;
 
         try {
-            acquiredLock = this.lock.tryLock(requestTimeout.getDuration(), requestTimeout.getTimeUnit());
+            if (Timeout.isPositive(requestTimeout)) {
+                acquiredLock = this.lock.tryLock(requestTimeout.getDuration(), requestTimeout.getTimeUnit());
+            } else {
+                this.lock.lock();
+                acquiredLock = true;
+            }
         } catch (final InterruptedException interruptedException) {
             Thread.currentThread().interrupt();
             future.cancel();