fix: Use CatalogCommitConflicts for TableRequirement #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @CTTY for this pr, generally LGTM! Left one comment to address.
crates/iceberg/src/error.rs
Outdated
| @@ -232,7 +234,7 @@ impl Error { | |||
| // internally. It's zero cost if backtrace is disabled. | |||
| backtrace: Backtrace::capture(), | |||
|
|
|||
| retryable: false, | |||
| retryable: kind == ErrorKind::CatalogCommitConflicts, | |||
There was a problem hiding this comment.
This is odd to me, I would expect explicit call to change the retryable property.
There was a problem hiding this comment.
Hmm I don't have a strong opinion on this, was just thinking it will be more convenient like this. Will fix this
liurenjie1024
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
ErrorKind::CatalogCommitConflictsforTableRequirement::checkErrorKind::TableNotFoundAre these changes tested?
No