-
Notifications
You must be signed in to change notification settings - Fork 288
fix: Use CatalogCommitConflicts for TableRequirement #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CTTY for this pr, generally LGTM! Left one comment to address.
crates/iceberg/src/error.rs
Outdated
@@ -232,7 +234,7 @@ impl Error { | |||
// internally. It's zero cost if backtrace is disabled. | |||
backtrace: Backtrace::capture(), | |||
|
|||
retryable: false, | |||
retryable: kind == ErrorKind::CatalogCommitConflicts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd to me, I would expect explicit call to change the retryable
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't have a strong opinion on this, was just thinking it will be more convenient like this. Will fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CTTY for this fix! LGTM!
Which issue does this PR close?
What changes are included in this PR?
ErrorKind::CatalogCommitConflicts
forTableRequirement::check
ErrorKind::TableNotFound
Are these changes tested?
No