Parquet: update PruneColumns to inherit from TypeWithSchemaVisitor to have Iceberg type #11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have Iceberg type
|
cc @rdblue and @RussellSpitzer |
| @@ -40,7 +43,7 @@ class PruneColumns extends ParquetTypeVisitor<Type> { | |||
| } | |||
|
|
|||
| @Override | |||
| public Type message(MessageType message, List<Type> fields) { | |||
| public Type message(StructType iStruct, MessageType message, List<Type> fields) { | |||
There was a problem hiding this comment.
We generally avoid names like iStruct, I would suggest something like tableStruct
There was a problem hiding this comment.
Checking other versions, we generally use expected for this struct
There was a problem hiding this comment.
You are right. We do use expected elsewhere. Updated.
RussellSpitzer
approved these changes
Sep 25, 2024
|
Thanks @aihuaxu , This should make our Variant work a lot easier (also potentially geometric work!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PruneColumns inherits from ParquetTypeVisitor which will only pass Parquet types. Later when we add the support for Variant type, we need to know the column is a Variant type during column pruning. Before logical Variant type is added to Parquet, we can change to inherit from TypeWithSchemaVisitor to have the Iceberg type. #11178
Existing tests in TestPruneColumns should provide the test coverage so no tests are added.