Raster processing and digital elevation models #890
Conversation
- The idea is to access gdal in a more idiomatic way. - For instance AutoCloseable is used to release the underlying resources systematically. - Objects ease the creation of options.
- The ContourTracer implements marching squares to trace or polygonize contours. - The HillshadeCalculator computes raster hillshades. - Martini is a port of mapbox's martini algorithm to java. - The ChaikinSmoother enable the smoothing of linestring and polygons. - Some tests and utilities enable the verification of the results.
- Improve the TileStore abstraction so that it can support both raster and vector tiles. - Add some TileStore for dealing with raster tiles (geotiff, dem, cache, etc.).
- The server can now serve raster and vector tiles. - New assets allow the previsualisation of DEM data
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
baremaps-core/src/main/java/org/apache/baremaps/tilestore/raster/BicubicInterpolation.java
Fixed
Show fixed
Hide fixed
baremaps-core/src/main/java/org/apache/baremaps/tilestore/raster/GeoTiffReader.java
Fixed
Show fixed
Hide fixed
...ps-core/src/test/java/org/apache/baremaps/tilestore/raster/VectorHillshadeTileStoreTest.java
Fixed
Show fixed
Hide fixed
baremaps-dem/src/test/java/org/apache/baremaps/dem/HillShadeRenderer.java
Fixed
Show fixed
Hide fixed
baremaps-gdal/src/main/java/org/apache/baremaps/gdal/TranslateOptions.java
Fixed
Show fixed
Hide fixed
bchapuis
force-pushed
the
raster-processing
branch
from
f61fd4c
to
812b75e
Compare
bchapuis
force-pushed
the
raster-processing
branch
from
812b75e
to
a44233e
Compare
baremaps-gdal/src/main/java/org/apache/baremaps/gdal/TranslateOptions.java
Fixed
Show fixed
Hide fixed
|
bchapuis
force-pushed
the
main
branch
3 times, most recently
from
3dbe1b7
to
7502fb1
Compare
| }, | ||
| sortOptions = false) | ||
| @SuppressWarnings("squid:S106") | ||
| public class DEM implements Runnable { |
There was a problem hiding this comment.
Maybe you could add some javadoc explaining DEM, maybe with external links
This comment applies to the Key classes (entry points of this new functionality)
| import picocli.CommandLine.Option; | ||
|
|
||
| @Command(name = "serve", description = "Start a tile server that serves elevation data.") | ||
| public class Serve implements Callable<Integer> { |
There was a problem hiding this comment.
Maybe add a line to define purpose of the Server
|
|
||
| var tileStoreSupplier = (Supplier<TileStore>) () -> tileCache; | ||
| var tileStoreSupplier = (Supplier<TileStore<ByteBuffer>>) () -> tileCache; |
There was a problem hiding this comment.
A<B> = slippery slope but looks good and makes sense.
| values); | ||
|
|
||
| return values; | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Suggestion: Limit the catch to declared exceptions (A | B |RuntimeException) ? (for consistency with line 78). This comment also applies to other places.
| /** {@inheritDoc} */ | ||
| @Override | ||
| public void close() throws Exception { | ||
| tileStore.close(); |
There was a problem hiding this comment.
If close fail. Don't we want to cleanup anyway ?
| var grid = geoTiffReader.read(tileCoord, 256, 4); | ||
|
|
||
| int increment = switch (tileCoord.z()) { | ||
| case 1 -> 2000; |
There was a problem hiding this comment.
Maybe link (in javadoc) to some justification behind the reasoning of this mapping, rather than leaving "magic" numbers.
|
|
||
| /** | ||
| * A geometry transformer that applies the Chaikin smoothing algorithm to the coordinates of a | ||
| * geometry. |
There was a problem hiding this comment.
Maybe a link explaining why/when to use this algorithm.
| import javax.swing.*; | ||
| import org.locationtech.jts.geom.Geometry; | ||
|
|
||
| public class ContourRenderer { |
There was a problem hiding this comment.
Javadoc especially important since it has a main()
| import org.locationtech.jts.geom.Polygon; | ||
| import org.locationtech.jts.geom.util.AffineTransformation; | ||
|
|
||
| public class MarchingSquareRenderer extends JPanel { |
There was a problem hiding this comment.
Javadoc especially since it has a main()
This pull request adds the ability to handle raster data and digital elevation models to produce vector contour and vector hillshades. Apache SIS is used to read raster data. While not used in core, a wrapper for GDAL has also been developped and may be used in workflow steps in the future. A few algorithms for converting raster data to vectors are also introduced.
The screenshot below depicts the convertion of a dem geotiff as terrarium png tiles, the creation of a raster hillshade, the creation of a vector hillshade, and the creation of vector contours.