Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI distribution #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonesbusy
Copy link

@jonesbusy jonesbusy commented Jan 13, 2025

Fix #317 (more details there)

Provide chart as OCI artifact on GHCR

I've tested the workflow changes on my fork: https://github.com/jonesbusy/incubator-devlake-helm-chart/actions/runs/12741995690

chart

chart2

Verified

This commit was signed with the committer’s verified signature.
jonesbusy Valentin Delaye
Signed-off-by: Valentin Delaye <[email protected]>
@klesh klesh requested a review from matrixji January 14, 2025 06:50
@klesh
Copy link
Contributor

klesh commented Jan 14, 2025

Hi, @matrixji Would you like to take a look at the PR when you find time. Thanks in advance.

@klesh
Copy link
Contributor

klesh commented Feb 6, 2025

Hi, @JorgeGar , would you like to take a look at the PR? Thanks

@JorgeGar
Copy link
Contributor

JorgeGar commented Feb 6, 2025

hey! It seems like @jonesbusy has been adding this funtionally all over GitHub repos 😄
IMHO it is fine, it is another way to deliver our chart to people, which will help us gain reach. I'm not personally familiar with this approach, but I don't see any issues.
@klesh if you're also happy with it, I'd be happy to introduce it.

@klesh
Copy link
Contributor

klesh commented Feb 7, 2025

@JorgeGar Sounds good to me.

@matrixji
Copy link
Member

matrixji commented Feb 7, 2025

LGTM.

@jonesbusy
Copy link
Author

Thanks! After merging would you mind doing a new release? So that we can start to consume the chart via GHCR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide charts through OCI registry
4 participants