kie-issues#1670: Migrate Apache licenses check to apache rat 0.17.x#3189
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the Apache RAT license header checking from version 0.16.1 to 0.17, addressing issue #1670. The update modifies how Apache RAT is invoked and how its output is parsed to detect license violations.
Key Changes:
- Upgraded Apache RAT from version 0.16.1 to 0.17
- Changed command-line arguments to use new syntax with
-Eflag and--separator - Implemented new output parsing logic with multiple grep patterns to detect unapproved licenses
- Enhanced error reporting with emoji indicators and formatted output extraction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@jomarko Can you please double-check if the below suggestions are reasonable? |
thiagoelg
approved these changes
Jan 13, 2026
This was referenced Jan 14, 2026
kie-issues#1670: Migrate Apache licenses check to apache rat 0.17.x
apache/incubator-kie-drools#6550
Merged
Merged
Merged
Member
|
@jomarko I assume you reviewed the below suggestions. |
baldimir
approved these changes
Feb 11, 2026
yesamer
approved these changes
Feb 12, 2026
Member
Author
|
Pushed updates to Apache RAT check was to ensure filename with Unapproved license is listed in github action. See apache/incubator-kie-kogito-runtimes#4154 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1670
Complete ensemble
JIRA
Referenced pull requests
Checklist
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] tests
for a full downstream build
please add comment: Jenkins run fdb
add the label
run_fdbfor a compile downstream build
please add comment: Jenkins run cdb
for a full production downstream build
please add comment: Jenkins execute product fdb
for an upstream build
please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-branch
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] native-lts
CI Status
You can check OptaPlanner repositories CI status from Chain Status webpage.
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.