Skip to content

kie-issues#1670: Migrate Apache licenses check to apache rat 0.17.x#3189

Merged
kbowers-ibm merged 4 commits into
apache:mainfrom
jomarko:kie-issues#1670
Feb 23, 2026
Merged

kie-issues#1670: Migrate Apache licenses check to apache rat 0.17.x#3189
kbowers-ibm merged 4 commits into
apache:mainfrom
jomarko:kie-issues#1670

Conversation

@jomarko
Copy link
Copy Markdown
Member

@jomarko jomarko commented Dec 23, 2025

Closes: apache/incubator-kie-issues#1670

Complete ensemble

JIRA

Referenced pull requests

Checklist

  • Documentation updated if applicable.
  • Release notes updated if applicable.
  • Upgrade recipe provided if applicable.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] tests

  • for a full downstream build

    • for jenkins job:
      please add comment: Jenkins run fdb
    • for github actions job:
      add the label run_fdb
  • for a compile downstream build
    please add comment: Jenkins run cdb

  • for a full production downstream build
    please add comment: Jenkins execute product fdb

  • for an upstream build
    please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-branch

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] native-lts

CI Status

You can check OptaPlanner repositories CI status from Chain Status webpage.

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Apache RAT license header checking from version 0.16.1 to 0.17, addressing issue #1670. The update modifies how Apache RAT is invoked and how its output is parsed to detect license violations.

Key Changes:

  • Upgraded Apache RAT from version 0.16.1 to 0.17
  • Changed command-line arguments to use new syntax with -E flag and -- separator
  • Implemented new output parsing logic with multiple grep patterns to detect unapproved licenses
  • Enhanced error reporting with emoji indicators and formatted output extraction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci_check_license_headers.yaml Outdated
Comment thread .github/workflows/ci_check_license_headers.yaml Outdated
Comment thread .github/workflows/ci_check_license_headers.yaml Outdated
@yesamer
Copy link
Copy Markdown
Member

yesamer commented Jan 7, 2026

@jomarko Can you please double-check if the below suggestions are reasonable?

@yesamer
Copy link
Copy Markdown
Member

yesamer commented Feb 11, 2026

@jomarko I assume you reviewed the below suggestions.

@jomarko
Copy link
Copy Markdown
Member Author

jomarko commented Feb 13, 2026

Pushed updates to Apache RAT check was to ensure filename with Unapproved license is listed in github action. See apache/incubator-kie-kogito-runtimes#4154 (comment)

@kbowers-ibm kbowers-ibm merged commit 1735f15 into apache:main Feb 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Apache licenses check to apache rat 0.17.x

6 participants