-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(duplication): make the task code for incremental loading from private logs configurable #2184
feat(duplication): make the task code for incremental loading from private logs configurable #2184
Conversation
Co-authored-by: Dan Wang <[email protected]>
Co-authored-by: Dan Wang <[email protected]>
Co-authored-by: Dan Wang <[email protected]>
Co-authored-by: Dan Wang <[email protected]>
Add some information about dup sending delayWe conducted multiple control experiments on the test cluster with
================================================== And here is an effect of adjusting the parameters of one of our online clusters:
|
What problem does this PR solve?
#2183
What is changed and how does it work?
We can make the task code configurable, allowing the thread priority incremental
loading from private logs of to be adjusted from LOW to COMMON, thereby
enabling support for low-latency real-time duplication.
Performance Testing
I do some test cases as following:
In these test cases, I first wrote 8k QPS of write traffic to the master cluster (this is the traffic that my test cluster will not generate dup log backlogs) to verify the effect of the priority modification. Then I wrote 20k QPS of write traffic to the master cluster (this is the traffic that my test cluster will generate a certain degree of dup log backlogs) to verify the effect of the priority modification.
As you see , change the priority from LOW to COMMON of
load_from_private_log
will not t increase the online delay. And priority from LOW to HIGH is no benefit for further speeding up duplication.So based on the above experimental conclusions, I think this issues' argument is valid.