Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix some typos in project #6911

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Conversation

psxjoy
Copy link
Contributor

@psxjoy psxjoy commented Oct 10, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

When I downloaded the src code, I found some typos in the project.
I think it should be a great opportunity to join seata's contributing journey.

Ⅱ. Does this pull request fix one issue?

Not applicable

Ⅲ. Why don't you add test cases (unit test/integration test)?

Only including typos fix.

Ⅳ. Describe how to verify it

Not applicable

Ⅴ. Special notes for reviews

@psxjoy psxjoy changed the title Fix: fix some typos in project optimize: fix some typos in project Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (87c1696) to head (161d33e).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...che/seata/core/rpc/netty/NettyClientBootstrap.java 0.00% 0 Missing and 2 partials ⚠️
...org/apache/seata/server/session/GlobalSession.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6911   +/-   ##
=========================================
  Coverage     52.53%   52.53%           
  Complexity     6544     6544           
=========================================
  Files          1122     1122           
  Lines         39857    39857           
  Branches       4670     4670           
=========================================
+ Hits          20938    20940    +2     
+ Misses        16924    16923    -1     
+ Partials       1995     1994    -1     
Files with missing lines Coverage Δ
.../org/apache/seata/config/ConfigurationFactory.java 39.47% <100.00%> (ø)
...seata/core/exception/TransactionExceptionCode.java 100.00% <100.00%> (ø)
.../java/org/apache/seata/core/protocol/Protocol.java 100.00% <100.00%> (ø)
...tasource/undo/oracle/OracleUndoInsertExecutor.java 55.55% <ø> (ø)
...octrl/eventing/impl/ProcessCtrlEventPublisher.java 100.00% <ø> (ø)
.../statelang/parser/impl/ServiceTaskStateParser.java 83.33% <ø> (ø)
.../apache/seata/server/storage/SessionConverter.java 89.51% <100.00%> (ø)
...org/apache/seata/server/session/GlobalSession.java 70.84% <0.00%> (ø)
...che/seata/core/rpc/netty/NettyClientBootstrap.java 54.65% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

@psxjoy Pleasse add this PR to change log here https://github.com/apache/incubator-seata/tree/2.x/changes

@psxjoy
Copy link
Contributor Author

psxjoy commented Oct 12, 2024

@xingfudeshi Thanks for your notice.
I have already added this PR's info into change log.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 12, 2024
@xingfudeshi xingfudeshi merged commit 66bd3a4 into apache:2.x Oct 12, 2024
7 checks passed
@psxjoy psxjoy deleted the fix-typo-20241010 branch October 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants