Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : skip sending some request if client-version is v0 #6998

Open
wants to merge 19 commits into
base: 2.x
Choose a base branch
from

Merge branch '2.x' into dev-2024-undolog-del

331afa7
Select commit
Loading
Failed to load commit list.
Open

optimize : skip sending some request if client-version is v0 #6998

Merge branch '2.x' into dev-2024-undolog-del
331afa7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 20, 2025 in 0s

52.15% (-0.01%) compared to a1aba35

View this Pull Request on Codecov

52.15% (-0.01%) compared to a1aba35

Details

Codecov Report

Attention: Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.

Project coverage is 52.15%. Comparing base (a1aba35) to head (331afa7).

Files with missing lines Patch % Lines
...va/org/apache/seata/core/rpc/MsgVersionHelper.java 30.76% 7 Missing and 2 partials ⚠️
...he/seata/core/rpc/netty/AbstractNettyRemoting.java 0.00% 6 Missing and 2 partials ⚠️
.../seata/core/protocol/VersionNotSupportMessage.java 0.00% 2 Missing ⚠️
...n/java/org/apache/seata/core/protocol/Version.java 0.00% 1 Missing ⚠️
...eata/core/rpc/netty/NettyClientChannelManager.java 0.00% 1 Missing ⚠️
...he/seata/core/rpc/netty/RmNettyRemotingClient.java 0.00% 1 Missing ⚠️
...he/seata/core/rpc/netty/TmNettyRemotingClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6998      +/-   ##
============================================
- Coverage     52.16%   52.15%   -0.01%     
- Complexity     6814     6817       +3     
============================================
  Files          1154     1156       +2     
  Lines         41116    41141      +25     
  Branches       4820     4825       +5     
============================================
+ Hits          21450    21459       +9     
- Misses        17628    17638      +10     
- Partials       2038     2044       +6
Files with missing lines Coverage Δ
...n/java/org/apache/seata/core/protocol/Version.java 69.04% <0.00%> (+0.75%) ⬆️
...eata/core/rpc/netty/NettyClientChannelManager.java 59.49% <0.00%> (-0.38%) ⬇️
...he/seata/core/rpc/netty/RmNettyRemotingClient.java 52.59% <0.00%> (ø)
...he/seata/core/rpc/netty/TmNettyRemotingClient.java 71.56% <0.00%> (ø)
.../seata/core/protocol/VersionNotSupportMessage.java 0.00% <0.00%> (ø)
...he/seata/core/rpc/netty/AbstractNettyRemoting.java 39.50% <0.00%> (-2.06%) ⬇️
...va/org/apache/seata/core/rpc/MsgVersionHelper.java 30.76% <30.76%> (ø)

... and 3 files with indirect coverage changes

View more details on Codecov