Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: caching the ConsistentHashSelector to avoid remapping when select every time. #7072

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

hein-hp
Copy link
Contributor

@hein-hp hein-hp commented Dec 23, 2024

Caching the ConsistentHashSelector to avoid remapping when select every time.

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Caching the ConsistentHashSelector to avoid remapping when select every time.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title optimize: Caching the ConsistentHashSelector to avoid remapping when select every time. optimize: caching the ConsistentHashSelector to avoid remapping when select every time. Mar 6, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit efa341a into apache:2.x Mar 7, 2025
6 checks passed
@slievrly slievrly added this to the 2.4.0 milestone Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.57%. Comparing base (117e57a) to head (507573f).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...scovery/loadbalance/ConsistentHashLoadBalance.java 83.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7072   +/-   ##
=========================================
  Coverage     51.56%   51.57%           
- Complexity     6812     6813    +1     
=========================================
  Files          1169     1169           
  Lines         41482    41505   +23     
  Branches       4851     4857    +6     
=========================================
+ Hits          21389    21405   +16     
- Misses        18072    18075    +3     
- Partials       2021     2025    +4     
Files with missing lines Coverage Δ
...scovery/loadbalance/ConsistentHashLoadBalance.java 84.31% <83.33%> (-1.41%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants