optimize: getLastVersionStateMachine sql adds condition 'LIMIT 1' #7184
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slievrly
reviewed
Mar 6, 2025
| @@ -62,6 +62,10 @@ public String getQueryStateMachinesByNameAndTenantSql(String dbType) { | |||
| return queryStateMachinesByNameAndTenantSql; | |||
| } | |||
|
|
|||
| public String getLastVersionStateMachine(String dbType) { | |||
| return getQueryStateMachinesByNameAndTenantSql(dbType) + " LIMIT 1"; | |||
There was a problem hiding this comment.
The LIMIT syntax is not part of the SQL standard, and there are several databases that do not support the LIMIT syntax.
There was a problem hiding this comment.
The LIMIT syntax is not part of the SQL standard, and there are several databases that do not support the LIMIT syntax.
OK, I will optimize it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7184 +/- ##
============================================
+ Coverage 51.56% 51.58% +0.01%
- Complexity 6812 6815 +3
============================================
Files 1169 1169
Lines 41482 41505 +23
Branches 4851 4857 +6
============================================
+ Hits 21389 21409 +20
- Misses 18072 18073 +1
- Partials 2021 2023 +2 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews