Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: skip the proxy of AbstractRoutingDataSource #7194

Merged

Conversation

iAmClever
Copy link
Contributor

@iAmClever iAmClever commented Mar 6, 2025

…tRoutingDataSource

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

automatically skipping proxy for datasource of type AbstractRoutingDataSource

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.55%. Comparing base (b530e30) to head (0f9d98e).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...on/datasource/SeataAutoDataSourceProxyCreator.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7194      +/-   ##
============================================
- Coverage     51.56%   51.55%   -0.01%     
- Complexity     6811     6812       +1     
============================================
  Files          1169     1169              
  Lines         41478    41482       +4     
  Branches       4851     4851              
============================================
- Hits          21388    21386       -2     
- Misses        18069    18073       +4     
- Partials       2021     2023       +2     
Files with missing lines Coverage Δ
...on/datasource/SeataAutoDataSourceProxyCreator.java 65.85% <40.00%> (-4.42%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@funky-eyes funky-eyes added this to the 2.4.0 milestone Mar 6, 2025
@funky-eyes funky-eyes changed the title optimize: automatically skipping proxy for datasource of type Abstrac… optimize: skip the proxy of AbstractRoutingDataSource Mar 6, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 117e57a into apache:2.x Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants