Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Improve] Add e2e identifier for create and edit actions button #4060

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

zzzk1
Copy link
Contributor

@zzzk1 zzzk1 commented Sep 13, 2024

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@zzzk1
Copy link
Contributor Author

zzzk1 commented Sep 13, 2024

flink-home, extlink, alarm etc components ' submit and cancel buttons look like not visible

@zzzk1 zzzk1 changed the title [Improve] Add e2e identifier for create and edit actions button [WIP][Improve] Add e2e identifier for create and edit actions button Sep 13, 2024
@zzzk1
Copy link
Contributor Author

zzzk1 commented Sep 13, 2024

Hi @wolfboys any suggestions for me?

@wolfboys
Copy link
Member

Hi @wolfboys any suggestions for me?

LGTM

Copy link

sonarcloud bot commented Sep 18, 2024

@zzzk1 zzzk1 changed the title [WIP][Improve] Add e2e identifier for create and edit actions button [Improve] Add e2e identifier for create and edit actions button Sep 18, 2024
@zzzk1 zzzk1 changed the title [Improve] Add e2e identifier for create and edit actions button [WIP][Improve] Add e2e identifier for create and edit actions button Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants