Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2062][FOLLOWUP]Improvement(dashboard): Display detailed info for application in dashboard ui #2063

Closed
wants to merge 1 commit into from

Conversation

lwllvyb
Copy link
Contributor

@lwllvyb lwllvyb commented Aug 19, 2024

What changes were proposed in this pull request?

  1. Display detailed info for application in dashboard ui
  2. Persist the application info in coordinator.
  3. Display application history information in dashboard ui.

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: #2062

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

Yes.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)
image

@lwllvyb lwllvyb changed the title [#2062][[FOLLOWUP]]Improvement[dashboard] Display detailed info for application in dashboard ui [#2062][FOLLOWUP]]Improvement[dashboard] Display detailed info for application in dashboard ui Aug 19, 2024
@lwllvyb lwllvyb changed the title [#2062][FOLLOWUP]]Improvement[dashboard] Display detailed info for application in dashboard ui [#2062][FOLLOWUP]Improvement[dashboard] Display detailed info for application in dashboard ui Aug 19, 2024
Copy link

Test Results

 2 792 files  ±0   2 792 suites  ±0   5h 51m 46s ⏱️ +20s
   988 tests ±0     987 ✅ ±0   1 💤 ±0  0 ❌ ±0 
12 403 runs  ±0  12 388 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 0f2a071. ± Comparison against base commit ba2302c.

@zuston
Copy link
Member

zuston commented Aug 22, 2024

This looks a huge change, could you help check this? @maobaolong If this has been applied in your internal cluster, please let me know, this will strength my approval confidence.

@maobaolong
Copy link
Member

@zuston yeah, this has been applied to our internal codebase and deployed in our RSS cluster already.

@lwllvyb
Copy link
Contributor Author

lwllvyb commented Aug 28, 2024

Ping @zuston @jerqi @maobaolong

@jerqi jerqi changed the title [#2062][FOLLOWUP]Improvement[dashboard] Display detailed info for application in dashboard ui [#2062][FOLLOWUP]Improvement(dashboard): Display detailed info for application in dashboard ui Aug 28, 2024
@jerqi
Copy link
Contributor

jerqi commented Aug 28, 2024

Could we use rocksDB to store the history data? If we load the history data, maybe we can't start coordinator quickly.

@lwllvyb
Copy link
Contributor Author

lwllvyb commented Aug 28, 2024

Could we use rocksDB to store the history data? If we load the history data, maybe we can't start coordinator quickly.

I am not good at rocksDB. Is it possible to open a new PR to optimize this using rocksDB?

Copy link
Member

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwllvyb Thanks for this improvement, it makes us easy to insight the detail of application anytime. Left minor comment inline.

@@ -29,4 +29,4 @@ rss.server.flush.localfile.threadPool.size 10
rss.server.flush.hadoop.threadPool.size 60
rss.server.disk.capacity 1g
rss.server.single.buffer.flush.enabled true
rss.server.single.buffer.flush.threshold 128m
rss.server.single.buffer.flush.threshold 128m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

<el-table-column label="Version" min-width="180">
<template v-slot="{ row }">
<div class="mb-4">
{{ row.version }}_{{ row.gitCommitId }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I want! 👍

@jerqi
Copy link
Contributor

jerqi commented Aug 28, 2024

Could we use rocksDB to store the history data? If we load the history data, maybe we can't start coordinator quickly.

I am not good at rocksDB. Is it possible to open a new PR to optimize this using rocksDB?

You should have a common abstraction both for file and Rocksdb first. What's more, you should reply my second question, f we load the history data, maybe we can't start coordinator quickly. How to handle this case.

@lwllvyb
Copy link
Contributor Author

lwllvyb commented Aug 28, 2024

Could we use rocksDB to store the history data? If we load the history data, maybe we can't start coordinator quickly.

I am not good at rocksDB. Is it possible to open a new PR to optimize this using rocksDB?

You should have a common abstraction both for file and Rocksdb first. What's more, you should reply my second question, f we load the history data, maybe we can't start coordinator quickly. How to handle this case.

Next, I will split this PR into more independent PRs and deal with the abstraction suggestion.
About you second question, coordinator only loads a portion of the latest history data, not the whole history data.

@jerqi
Copy link
Contributor

jerqi commented Aug 28, 2024

Could we use rocksDB to store the history data? If we load the history data, maybe we can't start coordinator quickly.

I am not good at rocksDB. Is it possible to open a new PR to optimize this using rocksDB?

You should have a common abstraction both for file and Rocksdb first. What's more, you should reply my second question, f we load the history data, maybe we can't start coordinator quickly. How to handle this case.

Next, I will split this PR into more independent PRs and deal with the abstraction suggestion. About you second question, coordinator only loads a portion of the latest history data, not the whole history data.

I can't see the logic to read part of history data. And although we only read part of data, the start time will still be long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Display more detailed information for application in dashboard ui.
4 participants