[MINOR] improve(client): Shuffle server list for MultiReplicaClientReadHandler to improve read serve performance #2067
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… serve performance
| @@ -49,7 +51,9 @@ public MultiReplicaClientReadHandler( | |||
| this.handlers = handlers; | |||
| this.blockIdBitmap = blockIdBitmap; | |||
| this.processedBlockIds = processedBlockIds; | |||
| this.shuffleServerInfos = shuffleServerInfos; | |||
| List<ShuffleServerInfo> shuffledServerList = new ArrayList<>(shuffleServerInfos); | |||
| Collections.shuffle(shuffledServerList); | |||
There was a problem hiding this comment.
In most cases, the complete data can be read from the first shuffle server. But the shuffle server with no data may be accessed first with this change.
|
Discussed with @xianjingfeng , this PR changed is affected for partition skew scenario. And I need to change the shuffle target to [0, writeReplica) since the [writeReplica, replica) could have no data for normal case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shuffle the server list for MultiReplicaClientReadHandler.
Why are the changes needed?
To improve read serve performance if enable multiply replication.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.