Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix: Change to get coordinator appCurrent value from metrics #2129

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

Change to get coordinator appCurrent value from metrics

Why are the changes needed?

Keep consistent with appTotality, and in case of incorrect result returned from getAppIds.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (d170004) to head (946633a).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
.../coordinator/web/resource/ApplicationResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2129      +/-   ##
============================================
+ Coverage     51.72%   52.40%   +0.68%     
+ Complexity     3275     3117     -158     
============================================
  Files           524      489      -35     
  Lines         29833    25756    -4077     
  Branches       2556     2420     -136     
============================================
- Hits          15431    13498    -1933     
+ Misses        13400    11369    -2031     
+ Partials       1002      889     -113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

 2 851 files   - 31   2 851 suites   - 31   5h 47m 1s ⏱️ - 10m 2s
 1 019 tests ± 0   1 017 ✅  -  1   1 💤 ±0  1 ❌ +1 
12 808 runs   - 60  12 792 ✅  - 61  15 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 946633a. ± Comparison against base commit 1d61e67.

@maobaolong
Copy link
Member Author

The failed test is not caused by this PR, it seems a flaky test.

Error:  Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 228.076 s <<< FAILURE! - in org.apache.uniffle.test.QuorumTest
Error:  case8  Time elapsed: 184.125 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
	at org.apache.uniffle.test.QuorumTest.case8(QuorumTest.java:829)

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi jerqi merged commit 3b01684 into apache:master Sep 24, 2024
41 of 43 checks passed
@maobaolong
Copy link
Member Author

@jerqi Thanks for your review!

maobaolong added a commit to maobaolong/incubator-uniffle that referenced this pull request Nov 4, 2024
…pache#2129)

### What changes were proposed in this pull request?

Change to get coordinator appCurrent value from metrics

### Why are the changes needed?

Keep consistent with `appTotality`, and in case of incorrect result returned from `getAppIds`.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

No need.

(cherry picked from commit 3b01684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants