Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes for compilation with raw mvn #426

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Baunsgaard
Copy link
Contributor

When opening Wayang in my IDE it produced many errors,

image

This PR fixes all of them (at least for my setup).

The main issue is that a default Java compile level is not set in the root POM.xml file, and therefore my IDE(vscode) does not know what to compile. While it is possible to add this as a configuration inside an individual's setup .vscode for Visual Code, I would still suggest moving it to a default setting. Because 1. the .vscode settings file is git ignored and 2. the IDE automatically picks up the default value set in the root parameters of the POM.xml.

The second issue i had was with wayang-api/wayang-api-scala-java/pom.xml.
Unfortunately, my IDE did not compile correctly without adding a recursive dependency on its package:

<dependency>
    <groupId>org.apache.wayang</groupId>
    <artifactId>wayang-api-scala-java_2.11</artifactId>
    <version>0.7.1</version>
</dependency>

Maybe there is a better way to handle this?

Finally, there were two minor bugs: 1. the docs pom contained the -SNAPSHOT when referencing the root repository, and 2. some imports contained an extra ;.

Afterwards:

image

@zkaoudi
Copy link
Contributor

zkaoudi commented Apr 9, 2024

Thanks a lot for this PR Sebastian.

@zkaoudi zkaoudi merged commit e7e91b2 into apache:main Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants