Minor changes for compilation with raw mvn #426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening Wayang in my IDE it produced many errors,
This PR fixes all of them (at least for my setup).
The main issue is that a default Java compile level is not set in the root POM.xml file, and therefore my IDE(vscode) does not know what to compile. While it is possible to add this as a configuration inside an individual's setup .vscode for Visual Code, I would still suggest moving it to a default setting. Because 1. the .vscode settings file is git ignored and 2. the IDE automatically picks up the default value set in the root parameters of the POM.xml.
The second issue i had was with wayang-api/wayang-api-scala-java/pom.xml.
Unfortunately, my IDE did not compile correctly without adding a recursive dependency on its package:
Maybe there is a better way to handle this?
Finally, there were two minor bugs: 1. the docs pom contained the -SNAPSHOT when referencing the root repository, and 2. some imports contained an extra
;
.Afterwards: