[remove datanode] Add Remove DataNode SQL #14678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuheng55555
suggested changes
Jan 17, 2025
Comment on lines
+468
to
+470
| removeDataNodeStatement | ||
| : REMOVE DATANODE dataNodeId=INTEGER_VALUE (',' dataNodeId=INTEGER_VALUE)* | ||
| ; |
Comment on lines
224
to
226
| DATANODEADDRESS | ||
| : D A T A N O D E A D D R E S S | ||
| ; |
| @@ -536,6 +536,11 @@ verifyConnection | |||
| : VERIFY CONNECTION (DETAILS)? | |||
| ; | |||
|
|
|||
| // ---- Remove DataNode | |||
| removeDataNode | |||
| : REMOVE DATANODE dataNodeId=INTEGER_LITERAL (COMMA dataNodeId=INTEGER_LITERAL)* | |||
There was a problem hiding this comment.
Both "datanode" and "datanodes" make sense in this context, so I’d prefer to leave it as is for now.
Comment on lines
2813
to
2814
| LOGGER.info( | ||
| "Start to remove datanode, removed DataNodes endpoint: {}", removeDataNodeLocations); |
There was a problem hiding this comment.
It's not recommended to print TDataNodeLocation directly, because it's too long.
Please consider RegionMaintainHandler.simplifiedLocation
Good point! With the addition of the remove datanode SQL, I feel the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
same as the title