Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor procedure framework (simplified StateMachineProcedure, and some other things) #14683

Merged

Conversation

liyuheng55555
Copy link
Collaborator

@liyuheng55555 liyuheng55555 commented Jan 13, 2025

  • Delete "suspend" operation
  • Delete "abort" operation
  • Rename KeepAliveWorker to TemporaryWorker
  • Refactor StateMachineProcedure:
    • Use LinkedList to replace array
  • And some other things

@liyuheng55555 liyuheng55555 changed the title Refactor procedure framework (simplified StateMachineProcedure, deleted KAWorker) Refactor procedure framework (simplified StateMachineProcedure, and some other things) Jan 13, 2025
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 41a49e7 into apache:master Jan 21, 2025
35 checks passed
liyuheng55555 added a commit to liyuheng55555/iotdb that referenced this pull request Jan 21, 2025
…ome other things) (apache#14683)

* delete KAWorking

* delete ProcedureSuspended

* delete "aborted" and suspended

* refactor states and delete stateCount

* refactor setNextState

* delete previousState

* spotless

* compile

* Revert "delete KAWorking"

This reverts commit 43176fa.

* recover KAWorker but rename it to TemporaryWorker

* spotless

* fix npe

* delete useless code

* delete useless code

* necessary log

(cherry picked from commit 41a49e7)
OneSizeFitsQuorum pushed a commit that referenced this pull request Jan 21, 2025
…ome other things) (#14683) (#14741)

* delete KAWorking

* delete ProcedureSuspended

* delete "aborted" and suspended

* refactor states and delete stateCount

* refactor setNextState

* delete previousState

* spotless

* compile

* Revert "delete KAWorking"

This reverts commit 43176fa.

* recover KAWorker but rename it to TemporaryWorker

* spotless

* fix npe

* delete useless code

* delete useless code

* necessary log

(cherry picked from commit 41a49e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants