-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor procedure framework (simplified StateMachineProcedure, and some other things) #14683
Merged
OneSizeFitsQuorum
merged 15 commits into
apache:master
from
liyuheng55555:Working/refactor-procedure-2
Jan 21, 2025
Merged
Refactor procedure framework (simplified StateMachineProcedure, and some other things) #14683
OneSizeFitsQuorum
merged 15 commits into
apache:master
from
liyuheng55555:Working/refactor-procedure-2
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liyuheng55555
commented
Jan 13, 2025
•
edited
Loading
edited
- Delete "suspend" operation
- Delete "abort" operation
- Rename KeepAliveWorker to TemporaryWorker
- Refactor StateMachineProcedure:
- Use LinkedList to replace array
- And some other things
This reverts commit 43176fa.
liyuheng55555
changed the title
Refactor procedure framework (simplified StateMachineProcedure, deleted KAWorker)
Refactor procedure framework (simplified StateMachineProcedure, and some other things)
Jan 13, 2025
OneSizeFitsQuorum
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
liyuheng55555
added a commit
to liyuheng55555/iotdb
that referenced
this pull request
Jan 21, 2025
…ome other things) (apache#14683) * delete KAWorking * delete ProcedureSuspended * delete "aborted" and suspended * refactor states and delete stateCount * refactor setNextState * delete previousState * spotless * compile * Revert "delete KAWorking" This reverts commit 43176fa. * recover KAWorker but rename it to TemporaryWorker * spotless * fix npe * delete useless code * delete useless code * necessary log (cherry picked from commit 41a49e7)
OneSizeFitsQuorum
pushed a commit
that referenced
this pull request
Jan 21, 2025
…ome other things) (#14683) (#14741) * delete KAWorking * delete ProcedureSuspended * delete "aborted" and suspended * refactor states and delete stateCount * refactor setNextState * delete previousState * spotless * compile * Revert "delete KAWorking" This reverts commit 43176fa. * recover KAWorker but rename it to TemporaryWorker * spotless * fix npe * delete useless code * delete useless code * necessary log (cherry picked from commit 41a49e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.