KAFKA-18553: Update javadoc and comments of ConfigType

JIRA: KAFKA-18553 The description of this class is outdated.
apache · Jan 19, 2025 · a0bc2b8 · a0bc2b8
1 parent 85ec8b5
commit a0bc2b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/core/src/main/scala/kafka/admin/ConfigCommand.scala b/core/src/main/scala/kafka/admin/ConfigCommand.scala
@@ -63,7 +63,7 @@ object ConfigCommand extends Logging {
 
   private val BrokerDefaultEntityName = ""
   val BrokerLoggerConfigType = "broker-loggers"
-  private val BrokerSupportedConfigTypes = ConfigType.ALL.asScala :+ BrokerLoggerConfigType :+ ConfigType.CLIENT_METRICS :+ ConfigType.GROUP
+  private val BrokerSupportedConfigTypes = ConfigType.ALL.asScala :+ BrokerLoggerConfigType
   private val DefaultScramIterations = 4096
 
   def main(args: Array[String]): Unit = {

diff --git a/server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java b/server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java
@@ -20,7 +20,7 @@
 import java.util.List;
 
 /**
- * Represents all the entities that can be configured via ZK
+ * Represents all the entities that can be configured.
  */
 public class ConfigType {
     public static final String TOPIC = "topics";
@@ -31,6 +31,5 @@ public class ConfigType {
     public static final String CLIENT_METRICS = "client-metrics";
     public static final String GROUP = "groups";
 
-    // Do not include ClientMetrics and Groups in `all` as they are not supported on ZK.
-    public static final List<String> ALL = Arrays.asList(TOPIC, CLIENT, USER, BROKER, IP);
+    public static final List<String> ALL = Arrays.asList(TOPIC, CLIENT, USER, BROKER, IP, CLIENT_METRICS, GROUP);
 }