Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18569: New consumer close may wait on unneeded FindCoordinator #18590

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

frankvicky
Copy link
Contributor

JIRA: KAFKA-18569
Please refer to ticker for further details.

In short, now new consumer close may wait for a FindCoordinator unsent request to go out when closing the consumer, even after the commit/leaveGroup stages of close are done.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community consumer clients small Small PRs labels Jan 17, 2025
@frankvicky
Copy link
Contributor Author

Hi @lianetm @kirktrue @chia7712
Please take a look when you have a free cycle.
Many thanks 🙇🏼

@kirktrue kirktrue added KIP-848 The Next Generation of the Consumer Rebalance Protocol ctr Consumer Threading Refactor (KIP-848) labels Jan 17, 2025
@kirktrue
Copy link
Collaborator

Thanks for the PR @frankvicky!

I was curious if you had a chance to look into using the pollOnClose() approach that was suggested in the Jira. If that approach works, we wouldn't need an extra ApplicationEvent.

Thanks!

@github-actions github-actions bot added the core Kafka Broker label Jan 18, 2025
@frankvicky
Copy link
Contributor Author

Hi @kirktrue
Thanks for the review.
You're right, it's easier than having a new event. 😺
Previously I thought following CommitRequestManager could have a unified close style.

JIRA: KAFKA-18569
Please refer to ticker for further details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved clients consumer core Kafka Broker ctr Consumer Threading Refactor (KIP-848) KIP-848 The Next Generation of the Consumer Rebalance Protocol small Small PRs triage PRs from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants