KAFKA-16368: Constraints update for segment.index.bytes #18596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jayteej
commented
Jan 17, 2025
| @@ -178,6 +178,8 @@ public static Map<String, String> createTopicConfigForRemoteStorage(boolean enab | |||
| // a "small" number of records (i.e. such that the average record size times the number of records is | |||
| // much less than the segment size), the number of records which hold in a segment is the multiple of 12 | |||
| // defined below. | |||
|
|
|||
| // TODO: WIP - Need to consider options for dealing with this segment roll approach not being valid for this PR. | |||
| topicProps.put(TopicConfig.SEGMENT_INDEX_BYTES_CONFIG, String.valueOf(12 * maxRecordBatchPerSegment)); | |||
There was a problem hiding this comment.
@divijvaidya let's discuss how best to handle this please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIP-1030: Update minimum for segment.index.bytes / log.index.size.max.bytes to 1KB.
WIP: Need to resolve issues with TieredStorageTestHarness using index.size to roll segments.