Skip to content

KAFKA-18516 Remove RackAwareMode #18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

KAFKA-18516 Remove RackAwareMode #18598

merged 1 commit into from
Jan 19, 2025

Conversation

m1a2st
Copy link
Collaborator

@m1a2st m1a2st commented Jan 17, 2025

Jira: https://issues.apache.org/jira/browse/KAFKA-18516

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@m1a2st m1a2st marked this pull request as ready for review January 17, 2025 14:27
@github-actions github-actions bot added triage PRs from the community core Kafka Broker small Small PRs labels Jan 17, 2025
frankvicky
frankvicky approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the triage PRs from the community label Jan 18, 2025
chia7712
chia7712 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RackAwareMode is used by AdminZkClient which is removed already.

@chia7712 chia7712 merged commit eb1c841 into apache:trunk Jan 19, 2025
9 of 10 checks passed
chia7712 pushed a commit that referenced this pull request Jan 19, 2025
@m1a2st @chia7712
KAFKA-18516 Remove RackAwareMode (#18598)
cfa481d 
Reviewers: TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
@m1a2st @pranavt84
KAFKA-18516 Remove RackAwareMode (apache#18598)
cad1b81 
Reviewers: TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
@m1a2st @mjsax
KAFKA-18516 Remove RackAwareMode (apache#18598)
7c5bb5c 
Reviewers: TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@m1a2st @manoj-mathivanan
KAFKA-18516 Remove RackAwareMode (apache#18598)
1a07d7a 
Reviewers: TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@frankvicky frankvicky frankvicky approved these changes

Assignees
No one assigned
Labels
ci-approved core Kafka Broker small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1a2st @chia7712 @frankvicky