Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18423: Remove ZkData #18605

Merged
merged 1 commit into from
Jan 19, 2025
Merged

KAFKA-18423: Remove ZkData #18605

merged 1 commit into from
Jan 19, 2025
+5 −455

Conversation

FrankYang0529
Copy link
Member

Remove ZkData and related unused references:

  • ZkNodeChangeNotificationListener
  • KafkaZkClient

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added the core Kafka Broker label Jan 18, 2025
@m1a2st
Copy link
Contributor

m1a2st commented Jan 18, 2025 •
edited
Loading

I think there are some Jira focus on removing other classes https://issues.apache.org/jira/browse/KAFKA-18430 and https://issues.apache.org/jira/browse/KAFKA-18427 , Could you focus on removing ZkData? Thanks for your helping.

ijuma
ijuma approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM (assuming the tests pass).

@ijuma
Copy link
Member

ijuma commented Jan 19, 2025

Java 17 passed, a few flakes for Java 23.

@ijuma ijuma merged commit 85ec8b5 into apache:trunk Jan 19, 2025
8 of 9 checks passed
@ijuma ijuma mentioned this pull request Jan 19, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
core Kafka Broker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYang0529 @m1a2st @ijuma