Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA 10409: Refactor Kakfa Streams RocksDB Iterators #18610

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

fonsdant
Copy link
Contributor

@fonsdant fonsdant commented Jan 18, 2025

Key refactorings:

  • Use RocksDBDualCFRangeIterator for DualColumnFamilyAccessor#all, since it iterate over all when passing null as from and to key ranges;
  • Create helper methods to:
    • loadNextKeys();
    • fetchNextKeyValue();
    • handleWithTimestampOnly();
    • handleNoTimestampOnly();
    • compareAndHandleKeys();
    • check if some key-value isInRange(); and
    • ensureOpen().
  • Rewrite methods with new helper methods:
    • makeNext();
    • next(); and
    • hasNext().
  • Improve members naming with:
    • noTimestampNext;
    • withTimestampNext;
    • noTimestampIterator; and
    • withTimestampIterator.
  • Sort members and method arguments alphanumerically;
  • Add documentation.

@github-actions github-actions bot added triage PRs from the community streams labels Jan 18, 2025
@fonsdant fonsdant force-pushed the kafka-10409/refactor-kafka-streams-rocksdb-iterators branch from c5f8d03 to f147674 Compare January 18, 2025 15:15
@fonsdant fonsdant force-pushed the kafka-10409/refactor-kafka-streams-rocksdb-iterators branch from f147674 to 3338e09 Compare January 18, 2025 15:18
@fonsdant fonsdant force-pushed the kafka-10409/refactor-kafka-streams-rocksdb-iterators branch from 3338e09 to 9a614c1 Compare January 18, 2025 19:06
@fonsdant fonsdant changed the title WIP KAFKA 10409: Refactor KAFKA Streams RocksDB Iterators KAFKA 10409: Refactor KAFKA Streams RocksDB Iterators Jan 18, 2025
@fonsdant fonsdant marked this pull request as ready for review January 18, 2025 19:09
@fonsdant fonsdant changed the title KAFKA 10409: Refactor KAFKA Streams RocksDB Iterators KAFKA 10409: Refactor Kakfa Streams RocksDB Iterators Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streams triage PRs from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant