HOTFIX: remove PageView example to support Java11 for :streams:examples module #19052
+4
−423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es module The PageView example depends on Connect to pull in Json (de)serializers, but Connect does not support Java11 any longer. To allow supporting Java11 for the Kafka Streams examples, this PR removes the PageView examples and Connect dependency.
gharris1727
reviewed
Feb 27, 2025
Co-authored-by: Greg Harris <[email protected]>
chia7712
reviewed
Feb 27, 2025
build.gradle
Outdated
| @@ -51,7 +51,7 @@ ext { | |||
| gradleVersion = versions.gradle | |||
| minClientJavaVersion = 11 | |||
| minNonClientJavaVersion = 17 | |||
| modulesNeedingJava11 = [":clients", ":generator", ":streams", ":streams:test-utils", ":streams-scala", ":test-common:test-common-util"] | |||
| modulesNeedingJava11 = [":clients", ":generator", ":streams", ":streams:examples", ":streams:test-utils", ":streams-scala", ":test-common:test-common-util"] | |||
There was a problem hiding this comment.
Nice find, and should we add examples module too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PageView example depends on Connect to pull in Json (de)serializers, but Connect does not support Java11 any longer.
To allow supporting Java11 for the Kafka Streams examples, this PR removes the PageView examples and Connect dependency.