KAFKA-17747: [1/N] Add MetadataHash field to Consumer/Share/StreamGroupMetadataValue #19504
+160
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dataValue Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
changed the title
Signed-off-by: PoAn Yang <[email protected]>
lucasbru
approved these changes
Apr 23, 2025
| @@ -300,12 +300,13 @@ public void testNewStreamsGroupEpochRecord() { | |||
| .setGroupId(GROUP_ID), | |||
| new ApiMessageAndVersion( | |||
| new StreamsGroupMetadataValue() | |||
| .setEpoch(42), | |||
| .setEpoch(42) | |||
| .setMetadataHash(42), | |||
There was a problem hiding this comment.
The only line where you put 42?
There was a problem hiding this comment.
Yeah, I followed epoch value to check we can get expected metadata hash with StreamsCoordinatorRecordHelpers.newStreamsGroupEpochRecord. It's like GroupCoordinatorRecordHelpersTest#testNewShareGroupEpochRecord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShareGroupMetadataValue, and StreamGroupMetadataValue.
GroupCoordinatorRecordHelpers#newConsumerGroupEpochRecord,
GroupCoordinatorRecordHelpers#newShareGroupEpochRecord, and
StreamsCoordinatorRecordHelpers#newStreamsGroupEpochRecord.
ConsumerGroupPartitionMetadataValue.
StreamGroupPartitionMetadataKey / StreamGroupPartitionMetadataValue will
be removed in next PR.
Reviewers: Lucas Brutschy [email protected], David Jacot
[email protected]