KAFKA-19042: [6/N] Move PlaintextConsumerFetchTest to client-integration-tests module #19520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Apr 20, 2025
| ); | ||
| } | ||
|
|
||
| assertEquals(expected, actual); |
There was a problem hiding this comment.
Could you please consider comparing the fields one by one to produce accurate error message?
for (var i = 0; i < consumerRecords.size(); i++) {
var producerRecord = producerRecords.get(i);
var consumerRecord = consumerRecords.get(i);
assertEquals(producerRecord.topic(), consumerRecord.topic());
assertEquals(producerRecord.partition(), consumerRecord.partition());
}There was a problem hiding this comment.
Sure, addressed it :)
Comment on lines
124
to
129
| try (Producer<byte[], byte[]> producer = cluster.producer()) { | ||
| for (var i = 0; i < numRecords; i++) { | ||
| sendRecord(producer, tp, startingTimestamp, i, -1); | ||
| } | ||
| producer.flush(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| try (Producer<byte[], byte[]> producer = cluster.producer()) { | |
| for (var i = 0; i < numRecords; i++) { | |
| sendRecord(producer, tp, startingTimestamp, i, -1); | |
| } | |
| producer.flush(); | |
| } | |
| sendRecords(cluster, tp, numRecords, startingTimestamp, -1); |
| TopicPartition tp, | ||
| int numRecords | ||
| ) { | ||
| sendRecords(cluster, tp, numRecords, System.currentTimeMillis(), -1); |
There was a problem hiding this comment.
Suggested change
| sendRecords(cluster, tp, numRecords, System.currentTimeMillis(), -1); | |
| sendRecords(cluster, tp, numRecords, System.currentTimeMillis()); |
| assertEquals("value " + keyAndValueIndex, new String(record.value())); | ||
| // this is true only because K and V are byte arrays | ||
| assertEquals(("key " + keyAndValueIndex).length(), record.serializedKeySize()); | ||
| assertEquals(("value " + keyAndValueIndex).length(), record.serializedValueSize()); |
There was a problem hiding this comment.
Could we define two static variables for "key " and "value "? They are reused many times in this class.
| private void testFetchOutOfRangeOffsetResetConfigEarliest(GroupProtocol groupProtocol) throws InterruptedException { | ||
| Map<String, Object> config = Map.of( | ||
| GROUP_PROTOCOL_CONFIG, groupProtocol.name().toLowerCase(Locale.ROOT), | ||
| FETCH_MAX_WAIT_MS_CONFIG, 0 |
There was a problem hiding this comment.
Could we add comment for this variable?
// ensure no in-flight fetch request so that the offset can be reset immediately
| Map<String, Object> config = Map.of( | ||
| GROUP_PROTOCOL_CONFIG, groupProtocol.name().toLowerCase(Locale.ROOT), | ||
| AUTO_OFFSET_RESET_CONFIG, "latest", | ||
| FETCH_MAX_WAIT_MS_CONFIG, 0 |
Comment on lines
468
to
469
| var produced = producedByPartition.getOrDefault(partition, Collections.emptyList()); | ||
| var consumed = consumedByPartition.getOrDefault(partition, Collections.emptyList()); |
There was a problem hiding this comment.
Suggested change
| var produced = producedByPartition.getOrDefault(partition, Collections.emptyList()); | |
| var consumed = consumedByPartition.getOrDefault(partition, Collections.emptyList()); | |
| var produced = producedByPartition.getOrDefault(partition, List.of()); | |
| var consumed = consumedByPartition.getOrDefault(partition, List.of()); |
| cluster.createTopic(topicName, partitionCount, (short) BROKER_COUNT); | ||
| } | ||
|
|
||
| List<TopicPartition> partitions = new ArrayList<>(); |
There was a problem hiding this comment.
Could we use HashSet here, so we don't need to use Set.copyOf?
Comment on lines
394
to
395
| var records = consumer.poll(Duration.ofMillis(20000)); | ||
| assertEquals(1, records.count()); |
There was a problem hiding this comment.
How about reusing consumeRecords?
Suggested change
| var records = consumer.poll(Duration.ofMillis(20000)); | |
| assertEquals(1, records.count()); | |
| var records = consumeRecords(consumer, 1); | |
| assertEquals(1, records.size()); |
Comment on lines
322
to
323
| var records = consumer.poll(Duration.ofMillis(20000)); | ||
| assertEquals(1, records.count()); |
There was a problem hiding this comment.
How about reusing consumerRecords?
Suggested change
| var records = consumer.poll(Duration.ofMillis(20000)); | |
| assertEquals(1, records.count()); | |
| var records = consumeRecords(consumer, 1); | |
| assertEquals(1, records.size()); |
|
Thanks for @FrankYang0529 comments, addressed all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Java to rewrite
PlaintextConsumerFetchTestby new test infra andmove it to client-integration-tests module.