KAFKA-17747: [2/N] Add compute topic and group hash #19523
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.coordinator.group; | ||
|
|
||
| import org.apache.kafka.common.Uuid; | ||
| import org.apache.kafka.image.MetadataImage; | ||
|
|
||
| import com.dynatrace.hash4j.hashing.Hashing; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertNotEquals; | ||
|
|
||
| public class UtilsTest { | ||
| private static final Uuid FOO_TOPIC_ID = Uuid.randomUuid(); | ||
| private static final String FOO_TOPIC_NAME = "foo"; | ||
| private static final String BAR_TOPIC_NAME = "bar"; | ||
| private static final int FOO_NUM_PARTITIONS = 2; | ||
| private static final MetadataImage FOO_METADATA_IMAGE = new MetadataImageBuilder() | ||
| .addTopic(FOO_TOPIC_ID, FOO_TOPIC_NAME, FOO_NUM_PARTITIONS) | ||
| .addRacks() | ||
| .build(); | ||
|
|
||
| @Test | ||
| void testComputeTopicHash() throws IOException { | ||
| long result = Utils.computeTopicHash(FOO_METADATA_IMAGE.topics().getTopic(FOO_TOPIC_ID), FOO_METADATA_IMAGE.cluster()); | ||
|
||
|
|
||
| long expected = Hashing.xxh3_64().hashStream() | ||
| .putByte((byte) 0) // magic byte | ||
| .putLong(FOO_TOPIC_ID.hashCode()) // topic ID | ||
| .putString(FOO_TOPIC_NAME) // topic name | ||
| .putInt(FOO_NUM_PARTITIONS) // number of partitions | ||
| .putInt(0) // partition 0 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack0") // The first rack in partition 0 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack1") // The second rack in partition 0 | ||
| .putInt(1) // partition 1 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack1") // The first rack in partition 1 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack2") // The second rack in partition 1 | ||
| .getAsLong(); | ||
| assertEquals(expected, result); | ||
| } | ||
|
|
||
| @Test | ||
| void testComputeTopicHashWithDifferentMagicByte() throws IOException { | ||
| long result = Utils.computeTopicHash(FOO_METADATA_IMAGE.topics().getTopic(FOO_TOPIC_ID), FOO_METADATA_IMAGE.cluster()); | ||
|
|
||
| long expected = Hashing.xxh3_64().hashStream() | ||
| .putByte((byte) 1) // magic byte | ||
| .putLong(FOO_TOPIC_ID.hashCode()) // topic ID | ||
| .putString(FOO_TOPIC_NAME) // topic name | ||
| .putInt(FOO_NUM_PARTITIONS) // number of partitions | ||
| .putInt(0) // partition 0 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack0") // The first rack in partition 0 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack1") // The second rack in partition 0 | ||
| .putInt(1) // partition 1 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack1") // The first rack in partition 1 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack2") // The second rack in partition 1 | ||
| .getAsLong(); | ||
| assertNotEquals(expected, result); | ||
| } | ||
|
|
||
| @Test | ||
| void testComputeTopicHashWithDifferentPartitionOrder() throws IOException { | ||
| long result = Utils.computeTopicHash(FOO_METADATA_IMAGE.topics().getTopic(FOO_TOPIC_ID), FOO_METADATA_IMAGE.cluster()); | ||
|
|
||
| long expected = Hashing.xxh3_64().hashStream() | ||
| .putByte((byte) 1) // magic byte | ||
| .putLong(FOO_TOPIC_ID.hashCode()) // topic ID | ||
| .putString(FOO_TOPIC_NAME) // topic name | ||
| .putInt(FOO_NUM_PARTITIONS) // number of partitions | ||
| .putInt(1) // partition 1 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack1") // The first rack in partition 1 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack2") // The second rack in partition 1 | ||
| .putInt(0) // partition 0 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack0") // The first rack in partition 0 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack1") // The second rack in partition 0 | ||
| .getAsLong(); | ||
| assertNotEquals(expected, result); | ||
| } | ||
|
|
||
| @Test | ||
| void testComputeTopicHashWithDifferentRackOrder() throws IOException { | ||
| long result = Utils.computeTopicHash(FOO_METADATA_IMAGE.topics().getTopic(FOO_TOPIC_ID), FOO_METADATA_IMAGE.cluster()); | ||
|
|
||
| long expected = Hashing.xxh3_64().hashStream() | ||
| .putByte((byte) 0) // magic byte | ||
| .putLong(FOO_TOPIC_ID.hashCode()) // topic ID | ||
| .putString(FOO_TOPIC_NAME) // topic name | ||
| .putInt(FOO_NUM_PARTITIONS) // number of partitions | ||
| .putInt(0) // partition 0 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack1") // The second rack in partition 0 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack0") // The first rack in partition 0 | ||
| .putInt(1) // partition 1 | ||
| .putInt(5) // length of rack0 | ||
| .putString("rack1") // The first rack in partition 1 | ||
| .putInt(5) // length of rack1 | ||
| .putString("rack2") // The second rack in partition 1 | ||
| .getAsLong(); | ||
| assertNotEquals(expected, result); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("differentFieldGenerator") | ||
| void testComputeTopicHashWithDifferentField(MetadataImage differentImage, Uuid topicId) throws IOException { | ||
| long result = Utils.computeTopicHash(FOO_METADATA_IMAGE.topics().getTopic(FOO_TOPIC_ID), FOO_METADATA_IMAGE.cluster()); | ||
|
|
||
| assertNotEquals( | ||
| Utils.computeTopicHash( | ||
| differentImage.topics().getTopic(topicId), | ||
| differentImage.cluster() | ||
| ), | ||
| result | ||
| ); | ||
| } | ||
|
|
||
| private static Stream<Arguments> differentFieldGenerator() { | ||
| Uuid differentTopicId = Uuid.randomUuid(); | ||
| return Stream.of( | ||
| Arguments.of(new MetadataImageBuilder() // different topic id | ||
| .addTopic(differentTopicId, FOO_TOPIC_NAME, FOO_NUM_PARTITIONS) | ||
| .addRacks() | ||
| .build(), | ||
| differentTopicId | ||
| ), | ||
|
||
| Arguments.of(new MetadataImageBuilder() // different topic name | ||
| .addTopic(FOO_TOPIC_ID, "bar", FOO_NUM_PARTITIONS) | ||
| .addRacks() | ||
| .build(), | ||
| FOO_TOPIC_ID | ||
| ), | ||
| Arguments.of(new MetadataImageBuilder() // different partitions | ||
| .addTopic(FOO_TOPIC_ID, FOO_TOPIC_NAME, 1) | ||
| .addRacks() | ||
| .build(), | ||
| FOO_TOPIC_ID | ||
| ), | ||
| Arguments.of(new MetadataImageBuilder() // different racks | ||
| .addTopic(FOO_TOPIC_ID, FOO_TOPIC_NAME, FOO_NUM_PARTITIONS) | ||
| .build(), | ||
| FOO_TOPIC_ID | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void testComputeGroupHashWithDifferentOrder() { | ||
| Map<String, Long> ascendTopicHashes = new LinkedHashMap<>(); | ||
| ascendTopicHashes.put(BAR_TOPIC_NAME, 123L); | ||
| ascendTopicHashes.put(FOO_TOPIC_NAME, 456L); | ||
|
|
||
| Map<String, Long> descendTopicHashes = new LinkedHashMap<>(); | ||
| descendTopicHashes.put(FOO_TOPIC_NAME, 456L); | ||
| descendTopicHashes.put(BAR_TOPIC_NAME, 123L); | ||
| assertEquals(Utils.computeGroupHash(ascendTopicHashes), Utils.computeGroupHash(descendTopicHashes)); | ||
| } | ||
|
|
||
| @Test | ||
| void testComputeGroupHashWithSameKeyButDifferentValue() { | ||
| Map<String, Long> map1 = Map.of( | ||
| BAR_TOPIC_NAME, 123L, | ||
| FOO_TOPIC_NAME, 456L | ||
| ); | ||
|
|
||
| Map<String, Long> map2 = Map.of( | ||
| BAR_TOPIC_NAME, 456L, | ||
| FOO_TOPIC_NAME, 123L | ||
| ); | ||
| assertNotEquals(Utils.computeGroupHash(map1), Utils.computeGroupHash(map2)); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it. Thanks.