MINOR: Move RaftManager interface to raft module #20366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
frankvicky
reviewed
Aug 18, 2025
|
|
Updated. Add license header to new file to fix build error. Thanks. |
chia7712
reviewed
Aug 18, 2025
| long createdTimeMs | ||
| ); | ||
|
|
||
| void register(RaftClient.Listener<T> listener); |
There was a problem hiding this comment.
register and leaderAndEpoch are also a part of RaftClient APIs. We could remove them from RaftManager, since callers can use client instead.
chia7712
reviewed
Aug 21, 2025
| override def voterNode(id: Int, listener: ListenerName): Option[Node] = { | ||
| client.voterNode(id, listener).toScala | ||
| override def voterNode(id: Int, listener: ListenerName): Optional[Node] = { | ||
| client.voterNode(id, listener) |
There was a problem hiding this comment.
If the delegation is only a single line and the client is an interface, perhaps we don't need to wrap it with RaftManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RaftManagerinterface to raft module, and remove theregisterandleaderAndEpochmethods since they are already part ofthe RaftClient APIs.