MINOR: Refactor snapshottableSize method for better readability and simplicity #20368
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
snapshottableSize(long epoch)
method previously contained unnecessary nested conditions and multiple redundantreturn baseSize();
statements. This refactor aims to simplify the method's control flow and improve code readability.Changes
epoch == LATEST_EPOCH
toepoch != LATEST_EPOCH
to avoid unnecessary else block usage.return baseSize();
statements into a single return at the end of the method.Before
After
Please let me know if any further adjustments are needed.
Thank you for your review!