KAFKA-19614: The records appended to the log are illegal because of an incorrect base offset during TestLinearWriteSpeed #20500
+149
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: Each append now writes to a new
MemoryRecords
batch instead of reusing a single batch object.Reasons: If we reuse the same batch, its
baseoffset
will keep accumulating.Performance demonstration:
original performance:


new performance:
There is no significant impact on performance after applying new method of writing info to log.