KAFKA-19802: Admin client changes for KIP-1226 #20771
Conversation
AndrewJSchofield
changed the title
AndrewJSchofield
changed the title
| private final Optional<Long> lag; | ||
|
|
||
| /** | ||
| * Construct a new StartPartitionOffsetInfo. |
There was a problem hiding this comment.
| * Construct a new StartPartitionOffsetInfo. | |
| * Construct a new SharePartitionOffsetInfo. |
| * Construct a new StartPartitionOffsetInfo. | ||
| * | ||
| * @param startOffset The share-partition start offset | ||
| * @param leaderEpoch The optional leader epoch of the start offset |
There was a problem hiding this comment.
I expect this is the leader epoch of the share partition, correct?
There was a problem hiding this comment.
@AndrewJSchofield thanks for this patch. I have two small questions. Please take a look.
| groupOffsetsListing.put(tp, null); | ||
| } else { | ||
| groupOffsetsListing.put(tp, new OffsetAndMetadata(startOffset, leaderEpoch, "")); | ||
| groupOffsetsListing.put(tp, new SharePartitionOffsetInfo(startOffset, leaderEpoch, Optional.empty())); |
There was a problem hiding this comment.
Pardon me, will the lag be implemented later?
There was a problem hiding this comment.
Yes. Very soon. https://issues.apache.org/jira/browse/KAFKA-19778 for the tasks we are implementing in parallel.
| /** | ||
| * Construct a new SharePartitionOffsetInfo. | ||
| * | ||
| * @param startOffset The share-partition start offset |
There was a problem hiding this comment.
Sorry, I'm a bit confused by this "start offset". For example, If a partition has a latest offset of 23547540 and a share consumer has a "start offset" of 23541472, how do we explain the difference between those numbers?
chia7712@fedora:~/project/kafka$ ./bin/kafka-get-offsets.sh --bootstrap-server localhost:20000 --topic chia
chia:0:23547540
chia7712@fedora:~/project/kafka$ ./bin/kafka-share-groups.sh --bootstrap-server localhost:20000 --offsets --describe --all-groups
GROUP TOPIC PARTITION START-OFFSET LAG
perf-share-consumer chia 0 23541472 -
There was a problem hiding this comment.
The start offset is a little like the committed offset for a consumer group. The lag is the number of records to be delivered between the start offset and the latest offset.
3 participants
Admin client changes for KIP-1226 which adds lag information for share
groups.
Reviewers: Lianet Magrans [email protected]