Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYLIN-5401]Optimize code logic for pushdown queries #2077

Open
wants to merge 3 commits into
base: kylin4
Choose a base branch
from

Conversation

yuanoOo
Copy link

@yuanoOo yuanoOo commented Jan 12, 2023

Proposed changes

It is found that the push-down query in kylin4.0.x is very slow for the simple query eg: select * from table limit 10. It should respond in seconds, but it often takes a few minutes, and the larger the query data set, the more time-consuming it takes Long, which is very abnormal.BI tools often execute some simple queries to display detailed data. Abnormal query duration often causes BI tools to time out and return error messages, which is very unfriendly to user experience.
Through investigation, it is found that there is a shuffle process in the query plan of this very simple detailed query, which is outrageous.
The main logic of Kylin executing push-down query is concentrated in org.apache.kylin.query.pushdown.SparkSqlClient.Unnecessary Spark DataFrame type transform in org.apache.kylin.query.pushdown.SparkSqlClient#DFToList is the main cause of this problem.

Branch to commit

  • Branch kylin3 for v2.x to v3.x
  • Branch kylin4 for v4.x
  • Branch kylin5 for v5.x

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] or [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@yuanoOo yuanoOo changed the title Enhancement: Optimize code logic for pushdown queries [KYLIN-5401]Optimize code logic for pushdown queries Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant