Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] parallel processing for column-based TRowSet generation #6667

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Sep 4, 2024

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

  • Improvement comparison:

  • Support parallel processing for column-based TRowSet generation, within a fork-join pool on the engine side

  • The order of columns in TRowSet is still guaranteed by sorting the column index, which is a very light cost operation

  • Add a config to enable/disable this feature

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (96c5632) to head (74106c7).

Files with missing lines Patch % Lines
...apache/kyuubi/engine/result/TRowSetGenerator.scala 0.00% 14 Missing ⚠️
...ain/scala/org/apache/kyuubi/util/ThreadUtils.scala 0.00% 9 Missing ⚠️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 5 Missing ⚠️
...kyuubi/engine/spark/operation/SparkOperation.scala 0.00% 4 Missing ⚠️
...gine/spark/schema/SparkArrowTRowSetGenerator.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6667   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         683     683           
  Lines       42213   42236   +23     
  Branches     5755    5756    +1     
======================================
- Misses      42213   42236   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants