Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code for Spark 3.5 extension #6975

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Mar 10, 2025

Why are the changes needed?

Simple refactoring to clean up the code for the Spark 3.5 extension, e.g., remove unnecessary *Base *Helper abstraction layers, remove code for legacy Spark versions.

Note: I don't touch ForcedMaxOutputRows* because I'm going to remove it in the next PR.

Preparation for Spark 4.0 support.

How was this patch tested?

Pass GHA.

Was this patch authored or co-authored using generative AI tooling?

No.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (85caea8) to head (b5a94a6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ache/kyuubi/sql/zorder/OptimizeZorderCommand.scala 0.00% 4 Missing ⚠️
...a/org/apache/kyuubi/sql/zorder/ResolveZorder.scala 0.00% 2 Missing ⚠️
...he/kyuubi/sql/zorder/OptimizeZorderStatement.scala 0.00% 1 Missing ⚠️
...in/scala/org/apache/kyuubi/sql/zorder/Zorder.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6975   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         689     693    +4     
  Lines       42637   42723   +86     
  Branches     5804    5813    +9     
======================================
- Misses      42637   42723   +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants