Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Oct 26, 2025

Why are the changes needed?

Support to get kyuubi server event with RESTful api

How was this patch tested?

UT.

Was this patch authored or co-authored using generative AI tooling?

No.

@turboFei turboFei changed the title Support to get kyuubi server event Support to get kyuubi server event with RESTful api /api/v1/admin/server/event Oct 26, 2025
@turboFei turboFei changed the title Support to get kyuubi server event with RESTful api /api/v1/admin/server/event Support to get kyuubi server event with RESTful api Oct 26, 2025
@turboFei turboFei force-pushed the server_event branch 2 times, most recently from b111637 to c0428a1 Compare October 26, 2025 21:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2025

Codecov Report

❌ Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (3b205a3) to head (aabf80e).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...he/kyuubi/client/api/v1/dto/KyuubiServerEvent.java 0.00% 62 Missing ⚠️
.../scala/org/apache/kyuubi/server/api/ApiUtils.scala 0.00% 13 Missing ⚠️
...in/java/org/apache/kyuubi/client/AdminRestApi.java 0.00% 3 Missing ⚠️
.../scala/org/apache/kyuubi/server/KyuubiServer.scala 0.00% 1 Missing ⚠️
...rg/apache/kyuubi/server/api/v1/AdminResource.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7232   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         696     697    +1     
  Lines       43530   43610   +80     
  Branches     5883    5893   +10     
======================================
- Misses      43530   43610   +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei requested a review from pan3793 October 27, 2025 03:32
@turboFei turboFei self-assigned this Oct 27, 2025
@turboFei turboFei added this to the v1.11.0 milestone Oct 27, 2025
serverEvent.state,
serverEvent.serverIP,
serverEvent.serverConf.asJava,
serverEvent.serverEnv.asJava,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a security perspective, we should redact sensitive info by default, maybe we can have a server side config to control the behavior, the candidate value can be ORIGINAL, REDACTED, NONE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I remember there was a similar discussion about retrieving batch info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants