[AUTHZ] Remove redundant concatenation with the list of conditions #7299
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7299 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 698 698
Lines 43646 43646
Branches 5894 5894
======================================
Misses 43646 43646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan3793
approved these changes
Jan 9, 2026
pan3793
pushed a commit
that referenced
this pull request
Jan 9, 2026
…f conditions ### Why are the changes needed? This concatenation with the list of conditions `conditionList` is redundant as the `columnPrune` method already contains it. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7299 from attilapiros/apiros_fix_1. Closes #7299 18af358 [attilapiros] Remove redundant concatenation with the list of conditions Authored-by: attilapiros <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 526a8aa) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Jan 9, 2026
…f conditions ### Why are the changes needed? This concatenation with the list of conditions `conditionList` is redundant as the `columnPrune` method already contains it. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7299 from attilapiros/apiros_fix_1. Closes #7299 18af358 [attilapiros] Remove redundant concatenation with the list of conditions Authored-by: attilapiros <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 526a8aa) Signed-off-by: Cheng Pan <[email protected]>
Member
|
thanks, merged to master/1.11.1/1.10.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This concatenation with the list of conditions
conditionListis redundant as thecolumnPrunemethod already contains it.How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.