Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature][EC] EC index rich, add last unlock time and add ec exit log push #4982

Merged
merged 18 commits into from
Nov 27, 2023

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

  • update default ec idle time to 10 min
  • update cs resource file download filename to tmp name Prevent duplicate
  • EC exits unexpectedly kills the actively task and pus log
  • C index rich, add last unlock time

Related issues/PRs

Related issues: #4980,#4981

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

# Conflicts:
#	linkis-computation-governance/linkis-entrance/src/main/java/org/apache/linkis/entrance/server/DefaultEntranceServer.java
#	linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/EntranceServer.scala
#	linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/conf/EntranceConfiguration.scala
#	linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/scheduler/EntranceGroupFactory.scala
logger.debug("jobRequest startMap param template name is empty")

logger.info("jobRequest startMap params :{} ", startMap)
val templateUuid = startMap.getOrDefault(LabelKeyConstant.TEMPLATE_CONF_KEY, "").toString
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entrance/src/main/scala/org/apache/linkis/entrance/interceptor/impl/TemplateConfUtils.scala:204: value TEMPLATE_CONF_KEY is not a member of object org.apache.linkis.manager.label.constant.LabelKeyConstant

val creatorECTypeMaxRunningJobs =
CreatorECTypeDefaultConf.getCreatorECTypeMaxRunningJobs(creatorName, ecType)
if (logger.isDebugEnabled)
logger.debug(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-11-26T15:43:55.2081518Z [ERROR] /home/runner/work/linkis/linkis/linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/scheduler/EntranceFIFOUserConsumer.scala:92: overloaded method value debug with alternatives:
2023-11-26T15:43:55.2084622Z   (x$1: org.slf4j.Marker,x$2: String,x$3: Object*)Unit <and>
2023-11-26T15:43:55.2085673Z   (x$1: String,x$2: Object*)Unit
2023-11-26T15:43:55.2086638Z  cannot be applied to (String, String, String, Int, Int)
2023-11-26T15:43:55.2154392Z [ERROR] /home/runner/work/linkis/linkis/linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/scheduler/EntranceFIFOUserConsumer.scala:100: overloaded method value error with alternatives:
2023-11-26T15:43:55.2157815Z   (x$1: org.slf4j.Marker,x$2: String,x$3: Object*)Unit <and>

Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casionone casionone merged commit b704a2a into apache:master Nov 27, 2023
11 of 12 checks passed
@peacewong peacewong deleted the master-1.5.0 branch November 28, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants