Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EnginePlugin][Spark]Turn off use secure random by default #5197

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

By default, strong random strings are turned off because this method can cause Java to hang; users can enable this feature through the configuration parameter linkis.pyspark.use.secure.random.

Related issues/PRs

Related issues: close #5196

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@casionone casionone merged commit 2fdf9d3 into apache:master Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Spark]The execution of SecureRandomStringUtils.random may get stuck.
2 participants