-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Signed-off-by: Serge Panev <[email protected]>
I prefer to add the type name in DataType class, and get the type name from ‘mshadow::DataType<DType>::kName’. |
AFAIK, we can't change |
8e7d963
to
3acd71e
Compare
Signed-off-by: Serge Panev <[email protected]>
3acd71e
to
a31b222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate feature with https://github.com/apache/incubator-mxnet/blob/master/src/common/utils.h#L368-L390
Signed-off-by: Serge Panev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Hi @haojin2 , the request has been addressed. Could you please help take a review? Thank you! |
Hi @haojin2 |
@haojin2 The reason is that the dtypes belong to mshadow, and it will be more convenient to get the name of mshadow::dtype. |
Description
Add a macro mapping mshadow type_flag to strings, to improve debuggability.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.