-
Notifications
You must be signed in to change notification settings - Fork 2.9k
NIFI-4196 - Expose AWS proxy authentication settings #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please note the displayName settings were not added as most of the AWS related processors lack these |
Hey @trixpan, regarding Besides, some tests are now failing:
|
hopefully fixed |
Thanks @trixpan, what about my comment on |
@pvillard31 will rebase and resubmit... |
How can these be tested? |
in #2588 I have done this as well, but only in my processor ( scope ). I would like to see this land. What can be done to move this forward? |
@trixpan can you de-conflict? |
NIFI-4196 - Fix jUnit errors This closes apache#2016. Signed-off-by: Koji Kawamura <[email protected]>
@trixpan Similar to #2018, I took the liberty of taking over this PR into #2704. By cherry-picking your commits into my branch, so that we can respect your work and, when mine is merged, this PR will be closed properly. I've rebased with the latest master, check unit tests and expand the proxy supports to other AWS processors, such as DynamoDB, Kinesis and Lambda there. @trixpan @ottobackwards @pvillard31 Please keep reviewing these stuffs at #2704. It's ready for finalizing review process. Thanks! |
NIFI-4196 - Fix jUnit errors This closes apache#2016. Signed-off-by: Koji Kawamura <[email protected]>
NIFI-4196 - Fix jUnit errors This closes apache#2016. Signed-off-by: Koji Kawamura <[email protected]>
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.